6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-03-22 10:36:10 +00:00
Code Issues Projects Releases Wiki Activity

Fix another case of a .comm directive without a corresponding .type

Browse Source 
directive.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@119073 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Rafael Espindola 2010-11-14 21:11:16 +00:00
parent 8d63ba8260
commit 55d02f3a13
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/MC/MCELFStreamer.cpp
View File

@ -409,9 +409,10 @@ void MCELFStreamer::EmitCommonSymbol(MCSymbol *Symbol, uint64_t Size,
if (!BindingExplicitlySet.count(Symbol)) {
SetBinding(SD, ELF::STB_GLOBAL);
SD.setExternal(true);
SetType(SD, ELF::STT_OBJECT);
}
SetType(SD, ELF::STT_OBJECT);
if (GetBinding(SD) == ELF_STB_Local) {
const MCSection *Section = getAssembler().getContext().getELFSection(".bss",
MCSectionELF::SHT_NOBITS,

21
test/MC/ELF/common.s
View File

@ -30,11 +30,24 @@
// CHECK-NEXT: ('st_value', 0x00000001)
// CHECK-NEXT: ('st_size', 0x00000001)
.local common6
.comm common6,8,16
// CHECK: # Symbol 0x00000003
// CHECK-NEXT: (('st_name', 0x00000011) # 'common6'
// CHECK-NEXT: ('st_bind', 0x00000000)
// CHECK-NEXT: ('st_type', 0x00000001)
// CHECK-NEXT: ('st_other', 0x00000000)
// CHECK-NEXT: ('st_shndx', 0x00000003)
// CHECK-NEXT: ('st_value', 0x00000010)
// CHECK-NEXT: ('st_size', 0x00000008)
// CHECK-NEXT: ),
// Test that without an explicit .local we produce a global.
.type common3,@object
.comm common3,4,4
// CHECK: ('st_name', 0x00000011) # 'common3'
// CHECK: ('st_name', 0x00000019) # 'common3'
// CHECK-NEXT: ('st_bind', 0x00000001)
// CHECK-NEXT: ('st_type', 0x00000001)
// CHECK-NEXT: ('st_other', 0x00000000)
@ -54,7 +67,7 @@ foo:
.type common4,@object
.comm common4,40,16
// CHECK: ('st_name', 0x0000001d) # 'common4'
// CHECK: ('st_name', 0x00000025) # 'common4'
// CHECK-NEXT: ('st_bind', 0x00000001)
// CHECK-NEXT: ('st_type', 0x00000001)
// CHECK-NEXT: ('st_other', 0x00000000)
@ -64,8 +77,8 @@ foo:
.comm common5,4,4
// CHECK: # Symbol 0x00000008
// CHECK-NEXT: (('st_name', 0x00000025) # 'common5'
// CHECK: # Symbol 0x00000009
// CHECK-NEXT: (('st_name', 0x0000002d) # 'common5'
// CHECK-NEXT: ('st_bind', 0x00000001)
// CHECK-NEXT: ('st_type', 0x00000001)
// CHECK-NEXT: ('st_other', 0x00000000)