6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-29 10:32:47 +00:00
Code Issues Projects Releases Wiki Activity

Fix Alias Bug

Browse Source 
Use memcpy to do type punning instead of a cast.  A cast or similar
operation through a union breaks strict aliasing rules.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@172081 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Greene 2013-01-10 18:17:54 +00:00
parent c560bf638b
commit 5e1b31bf55
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
unittests/Support/YAMLIOTest.cpp
View File

@ -783,10 +783,18 @@ namespace yaml {
static void mapping(IO &io, KindAndFlags& kf) { static void mapping(IO &io, KindAndFlags& kf) {
io.mapRequired("kind", kf.kind); io.mapRequired("kind", kf.kind);
// type of flags field varies depending on kind field // type of flags field varies depending on kind field
if ( kf.kind == kindA )
io.mapRequired("flags", *((AFlags*)&kf.flags)); // Use memcpy here to avoid breaking strict aliasing rules.
else if ( kf.kind == kindA ) {
io.mapRequired("flags", *((BFlags*)&kf.flags)); AFlags aflags;
memcpy(&aflags, &kf.flags, sizeof(aflags));
io.mapRequired("flags", aflags);
}
else {
BFlags bflags;
memcpy(&bflags, &kf.flags, sizeof(bflags));
io.mapRequired("flags", bflags);
}
} }
}; };
} }