6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-26 21:32:10 +00:00
Code Issues Projects Releases Wiki Activity

Disallow global aliases to bitcast between address spaces

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186767 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Matt Arsenault 2013-07-20 17:46:05 +00:00
parent 3f49322818
commit 5f53c3be6f
2 changed files with 23 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
lib/IR/Verifier.cpp
View File

@ -498,18 +498,29 @@ void Verifier::visitGlobalAlias(GlobalAlias &GA) {
"Alias and aliasee types should match!", &GA);
Assert1(!GA.hasUnnamedAddr(), "Alias cannot have unnamed_addr!", &GA);
if (!isa<GlobalValue>(GA.getAliasee())) {
const ConstantExpr *CE = dyn_cast<ConstantExpr>(GA.getAliasee());
Constant *Aliasee = GA.getAliasee();
if (!isa<GlobalValue>(Aliasee)) {
ConstantExpr *CE = dyn_cast<ConstantExpr>(Aliasee);
Assert1(CE &&
(CE->getOpcode() == Instruction::BitCast ||
CE->getOpcode() == Instruction::GetElementPtr) &&
isa<GlobalValue>(CE->getOperand(0)),
"Aliasee should be either GlobalValue or bitcast of GlobalValue",
&GA);
if (CE->getOpcode() == Instruction::BitCast) {
unsigned SrcAS = CE->getOperand(0)->getType()->getPointerAddressSpace();
unsigned DstAS = CE->getType()->getPointerAddressSpace();
Assert1(SrcAS == DstAS,
"Alias bitcasts cannot be between different address spaces",
&GA);
}
}
const GlobalValue* Aliasee = GA.resolveAliasedGlobal(/*stopOnWeak*/ false);
Assert1(Aliasee,
const GlobalValue* Resolved = GA.resolveAliasedGlobal(/*stopOnWeak*/ false);
Assert1(Resolved,
"Aliasing chain should end with function or global variable", &GA);
visitGlobalValue(GA);

8
test/Verifier/bitcast-alias-address-space.ll Normal file
View File

@ -0,0 +1,8 @@
; RUN: not llvm-as -verify -disable-output %s
target datalayout = "e-p:32:32:32-p1:16:16:16-p2:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n8:16:32"
@data = addrspace(2) global i32 27
@illegal_alias_data = alias bitcast (i32 addrspace(2)* @data to i32 addrspace(1)*)