6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-14 00:32:55 +00:00
Code Issues Projects Releases Wiki Activity

[SROA] Fix a *glaring* bug in r202091: you have to actually *write*

Browse Source 
the break statement, not just think it to yourself....

No idea how this worked at all, much less survived most bots, my
bootstrap, and some bot bootstraps!

The Polly one didn't survive, and this was filed as PR18959. I don't
have a reduced test case and honestly I'm not seeing the need. What we
probably need here are better asserts / debug-build behavior in
SmallPtrSet so that this madness doesn't make it so far.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@202129 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2014-02-25 09:45:27 +00:00
parent 8eb76420cd
commit 64d5fd932b
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/Transforms/Scalar/SROA.cpp
View File

@ -3169,6 +3169,7 @@ bool SROA::rewritePartition(AllocaInst &AI, AllocaSlices &S,
Promotable = false;
PHIUsers.clear();
SelectUsers.clear();
break;
}
for (SmallPtrSetImpl<SelectInst *>::iterator I = SelectUsers.begin(),
E = SelectUsers.end();
@ -3177,6 +3178,7 @@ bool SROA::rewritePartition(AllocaInst &AI, AllocaSlices &S,
Promotable = false;
PHIUsers.clear();
SelectUsers.clear();
break;
}
if (Promotable) {