6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-22 13:29:44 +00:00
Code Issues Projects Releases Wiki Activity

DebugInfo: Add FIXME regarding DILexicalBlock uniquing fields.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@208909 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie 2014-05-15 20:09:55 +00:00
parent 522a941c17
commit 675e527ab8
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/IR/DIBuilder.cpp
View File

@ -1226,6 +1226,13 @@ DILexicalBlockFile DIBuilder::createLexicalBlockFile(DIDescriptor Scope,
DILexicalBlock DIBuilder::createLexicalBlock(DIDescriptor Scope, DIFile File, DILexicalBlock DIBuilder::createLexicalBlock(DIDescriptor Scope, DIFile File,
unsigned Line, unsigned Col, unsigned Line, unsigned Col,
unsigned Discriminator) { unsigned Discriminator) {
// FIXME: This isn't thread safe nor the right way to defeat MDNode uniquing.
// I believe the right way is to have a self-referential element in the node.
// Also: why do we bother with line/column - they're not used and the
// documentation (SourceLevelDebugging.rst) claims the line/col are necessary
// for uniquing, yet then we have this other solution (because line/col were
// inadequate) anyway. Remove all 3 and replace them with a self-reference.
// Defeat MDNode uniquing for lexical blocks by using unique id. // Defeat MDNode uniquing for lexical blocks by using unique id.
static unsigned int unique_id = 0; static unsigned int unique_id = 0;
Value *Elts[] = { Value *Elts[] = {