6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-13 10:32:06 +00:00
Code Issues Projects Releases Wiki Activity

Check whether functions have any lines associated before emitting coverage info for them. This isn't just a size/time saving, gcov may crash on these.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206671 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nick Lewycky 2014-04-18 23:32:28 +00:00
parent aae82fb2f7
commit 6b2b2043c9
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Transforms/Instrumentation/GCOVProfiling.cpp
View File

@ -449,6 +449,21 @@ bool GCOVProfiler::runOnModule(Module &M) {
return false; return false;
} }
static bool functionHasLines(Function *F) {
// Check whether this function actually has any source lines. Not only
// do these waste space, they also can crash gcov.
for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) {
for (BasicBlock::iterator I = BB->begin(), IE = BB->end();
I != IE; ++I) {
const DebugLoc &Loc = I->getDebugLoc();
if (Loc.isUnknown()) continue;
if (Loc.getLine() != 0)
return true;
}
}
return false;
}
void GCOVProfiler::emitProfileNotes() { void GCOVProfiler::emitProfileNotes() {
NamedMDNode *CU_Nodes = M->getNamedMetadata("llvm.dbg.cu"); NamedMDNode *CU_Nodes = M->getNamedMetadata("llvm.dbg.cu");
if (!CU_Nodes) return; if (!CU_Nodes) return;
@ -474,6 +489,7 @@ void GCOVProfiler::emitProfileNotes() {
Function *F = SP.getFunction(); Function *F = SP.getFunction();
if (!F) continue; if (!F) continue;
if (!functionHasLines(F)) continue;
// gcov expects every function to start with an entry block that has a // gcov expects every function to start with an entry block that has a
// single successor, so split the entry block to make sure of that. // single successor, so split the entry block to make sure of that.
@ -549,6 +565,7 @@ bool GCOVProfiler::emitProfileArcs() {
continue; continue;
Function *F = SP.getFunction(); Function *F = SP.getFunction();
if (!F) continue; if (!F) continue;
if (!functionHasLines(F)) continue;
if (!Result) Result = true; if (!Result) Result = true;
unsigned Edges = 0; unsigned Edges = 0;
for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) { for (Function::iterator BB = F->begin(), E = F->end(); BB != E; ++BB) {