6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-23 02:32:11 +00:00
Code Issues Projects Releases Wiki Activity

Properties where both Values weren't in the union (as being equal to

Browse Source 
another Value) weren't being found by findProperties.

This fixes predsimplify.ll test6, a missed optimization opportunity.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@29991 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Nick Lewycky 2006-08-31 00:39:16 +00:00
parent d3233eeff2
commit 6e39c7ed1e
1 changed files with 18 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
lib/Transforms/Scalar/PredicateSimplifier.cpp
View File

@ -121,21 +121,8 @@ namespace {
void addNotEqual(Value *V1, Value *V2) { void addNotEqual(Value *V1, Value *V2) {
DEBUG(std::cerr << "not equal: " << *V1 << " and " << *V2 << "\n"); DEBUG(std::cerr << "not equal: " << *V1 << " and " << *V2 << "\n");
V1 = canonicalize(V1); if (findProperty(NE, V1, V2) != Properties.end())
V2 = canonicalize(V2); return; // found.
// Does the property already exist?
for (PropertyIterator I = Properties.begin(), E = Properties.end();
I != E; ++I) {
if (I->Opcode != NE) continue;
I->V1 = canonicalize(I->V1);
I->V2 = canonicalize(I->V2);
if ((I->V1 == V1 && I->V2 == V2) ||
(I->V1 == V2 && I->V2 == V1)) {
return; // Found.
}
}
// Add the property. // Add the property.
Properties.push_back(Property(NE, V1, V2)); Properties.push_back(Property(NE, V1, V2));
@ -146,9 +133,8 @@ namespace {
assert(Opcode != EQ && "Can't findProperty on EQ." assert(Opcode != EQ && "Can't findProperty on EQ."
"Use the lookup method instead."); "Use the lookup method instead.");
V1 = lookup(V1); V1 = canonicalize(V1);
V2 = lookup(V2); V2 = canonicalize(V2);
if (!V1 || !V2) return Properties.end();
// Does the property already exist? // Does the property already exist?
for (PropertyIterator I = Properties.begin(), E = Properties.end(); for (PropertyIterator I = Properties.begin(), E = Properties.end();
@ -170,18 +156,16 @@ namespace {
assert(Opcode != EQ && "Can't findProperty on EQ." assert(Opcode != EQ && "Can't findProperty on EQ."
"Use the lookup method instead."); "Use the lookup method instead.");
V1 = lookup(V1); V1 = canonicalize(V1);
V2 = lookup(V2); V2 = canonicalize(V2);
if (!V1 || !V2) return Properties.end();
// Does the property already exist? // Does the property already exist?
for (ConstPropertyIterator I = Properties.begin(), for (ConstPropertyIterator I = Properties.begin(),
E = Properties.end(); I != E; ++I) { E = Properties.end(); I != E; ++I) {
if (I->Opcode != Opcode) continue; if (I->Opcode != Opcode) continue;
Value *v1 = lookup(I->V1), Value *v1 = canonicalize(I->V1),
*v2 = lookup(I->V2); *v2 = canonicalize(I->V2);
if (!v1 || !v2) continue;
if ((v1 == V1 && v2 == V2) || if ((v1 == V1 && v2 == V2) ||
(v1 == V2 && v2 == V1)) { (v1 == V2 && v2 == V1)) {
return I; // Found. return I; // Found.
@ -291,6 +275,14 @@ namespace {
public: public:
void debug(std::ostream &os) const { void debug(std::ostream &os) const {
for (EquivalenceClasses<Value*>::iterator I = union_find.begin(),
E = union_find.end(); I != E; ++I) {
if (!I->isLeader()) continue;
for (EquivalenceClasses<Value*>::member_iterator MI =
union_find.member_begin(I); MI != union_find.member_end(); ++MI)
std::cerr << **MI << " ";
std::cerr << "\n--\n";
}
} }
std::vector<Property> Properties; std::vector<Property> Properties;
@ -571,8 +563,10 @@ void PredicateSimplifier::visit(BranchInst *BI,
PropertySet TrueProperties(KP), FalseProperties(KP); PropertySet TrueProperties(KP), FalseProperties(KP);
DEBUG(std::cerr << "true set:\n"); DEBUG(std::cerr << "true set:\n");
TrueProperties.addEqual(ConstantBool::True, Condition); TrueProperties.addEqual(ConstantBool::True, Condition);
DEBUG(TrueProperties.debug(std::cerr));
DEBUG(std::cerr << "false set:\n"); DEBUG(std::cerr << "false set:\n");
FalseProperties.addEqual(ConstantBool::False, Condition); FalseProperties.addEqual(ConstantBool::False, Condition);
DEBUG(FalseProperties.debug(std::cerr));
PropertySet KPcopy(KP); PropertySet KPcopy(KP);
proceedToSuccessor(KP, TrueProperties, Node, DT->getNode(TrueDest)); proceedToSuccessor(KP, TrueProperties, Node, DT->getNode(TrueDest));