From 70644e92d810f36710bc289cda11e982b399fc88 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sat, 9 Jan 2010 02:02:37 +0000 Subject: [PATCH] clean up this code, add a fixme. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93042 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Bitcode/Reader/BitcodeReader.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/Bitcode/Reader/BitcodeReader.cpp b/lib/Bitcode/Reader/BitcodeReader.cpp index bec9c50e301..87c4fd77f36 100644 --- a/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/lib/Bitcode/Reader/BitcodeReader.cpp @@ -789,18 +789,18 @@ bool BitcodeReader::ParseMetadata() { unsigned Size = Record.size(); SmallVector Elts; for (unsigned i = 0; i != Size; ++i) { - if (Record[i] == ~0U) + if (Record[i] == ~0U) { Elts.push_back(NULL); - else { - Value *MD = MDValueList.getValueFwdRef(Record[i]); - if (MDNode *B = dyn_cast(MD)) - Elts.push_back(B); - else - return Error("Malformed metadata record"); + continue; } + MDNode *MD = dyn_cast(MDValueList.getValueFwdRef(Record[i])); + if (MD == 0) + return Error("Malformed metadata record"); + Elts.push_back(MD); } Value *V = NamedMDNode::Create(Context, Name.str(), Elts.data(), Elts.size(), TheModule); + // FIXME: This shouldn't poke NextValueNo? MDValueList.AssignValue(V, NextValueNo++); break; }