diff --git a/lib/Analysis/BasicAliasAnalysis.cpp b/lib/Analysis/BasicAliasAnalysis.cpp index d9587463591..d0620456399 100644 --- a/lib/Analysis/BasicAliasAnalysis.cpp +++ b/lib/Analysis/BasicAliasAnalysis.cpp @@ -611,18 +611,39 @@ BasicAliasAnalysis::CheckGEPInstructions( if (G1OC != G2OC) { // Handle the "be careful" case above: if this is an array/vector // subscript, scan for a subsequent variable array index. - if (isa(BasePtr1Ty)) { - const Type *NextTy = - cast(BasePtr1Ty)->getElementType(); + if (const SequentialType *STy = + dyn_cast(BasePtr1Ty)) { + const Type *NextTy = STy; bool isBadCase = false; - for (unsigned Idx = FirstConstantOper+1; + for (unsigned Idx = FirstConstantOper; Idx != MinOperands && isa(NextTy); ++Idx) { const Value *V1 = GEP1Ops[Idx], *V2 = GEP2Ops[Idx]; if (!isa(V1) || !isa(V2)) { isBadCase = true; break; } + // If the array is indexed beyond the bounds of the static type + // at this level, it will also fall into the "be careful" case. + // It would theoretically be possible to analyze these cases, + // but for now just be conservatively correct. + if (const ArrayType *ATy = dyn_cast(STy)) + if (cast(G1OC)->getZExtValue() >= + ATy->getNumElements() || + cast(G2OC)->getZExtValue() >= + ATy->getNumElements()) { + isBadCase = true; + break; + } + if (const VectorType *VTy = dyn_cast(STy)) + if (cast(G1OC)->getZExtValue() >= + VTy->getNumElements() || + cast(G2OC)->getZExtValue() >= + VTy->getNumElements()) { + isBadCase = true; + break; + } + STy = cast(NextTy); NextTy = cast(NextTy)->getElementType(); } diff --git a/test/Analysis/BasicAA/constant-over-index.ll b/test/Analysis/BasicAA/constant-over-index.ll new file mode 100644 index 00000000000..e92995be5e6 --- /dev/null +++ b/test/Analysis/BasicAA/constant-over-index.ll @@ -0,0 +1,27 @@ +; RUN: llvm-as < %s | opt -aa-eval -print-all-alias-modref-info \ +; RUN: |& grep {MayAlias: double\\* \[%\]p.0.i.0, double\\* \[%\]p3\$} +; PR4267 + +; %p3 is equal to %p.0.i.0 on the second iteration of the loop, +; so MayAlias is needed. + +define void @foo([3 x [3 x double]]* noalias %p) { +entry: + %p3 = getelementptr [3 x [3 x double]]* %p, i64 0, i64 0, i64 3 + br label %loop + +loop: + %i = phi i64 [ 0, %entry ], [ %i.next, %loop ] + + %p.0.i.0 = getelementptr [3 x [3 x double]]* %p, i64 0, i64 %i, i64 0 + + volatile store double 0.0, double* %p3 + volatile store double 0.1, double* %p.0.i.0 + + %i.next = add i64 %i, 1 + %cmp = icmp slt i64 %i.next, 3 + br i1 %cmp, label %loop, label %exit + +exit: + ret void +}