From 73ce2886b1c3537eb592bc8450b96ce63cbe2f85 Mon Sep 17 00:00:00 2001 From: Robin Morisset Date: Tue, 23 Sep 2014 23:18:01 +0000 Subject: [PATCH] Fix swift-atomics testcase This testcase was not testing what it meant: because there were only two checks for dmb {{ish}} in the second function, it could have missed a bug where one of the three required dmb {{ish}} became dmb {{ishst}}. As I was fixing it, I also added CHECK-LABELs to make it a bit less brittle. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@218341 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/CodeGen/ARM/swift-atomics.ll | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/test/CodeGen/ARM/swift-atomics.ll b/test/CodeGen/ARM/swift-atomics.ll index 1d718155710..8b100f1f41f 100644 --- a/test/CodeGen/ARM/swift-atomics.ll +++ b/test/CodeGen/ARM/swift-atomics.ll @@ -8,6 +8,7 @@ define void @test_store_release(i32* %p, i32 %v) { ; CHECK: dmb ishst ; CHECK: str +; CHECK-STRICT-ATOMIC-LABEL: test_store_release: ; CHECK-STRICT-ATOMIC: dmb {{ish$}} store atomic i32 %v, i32* %p release, align 4 ret void @@ -24,7 +25,11 @@ define i32 @test_seq_cst(i32* %p, i32 %v) { ; CHECK: ldr ; CHECK: dmb {{ish$}} +; CHECK-STRICT-ATOMIC-LABEL: test_seq_cst: ; CHECK-STRICT-ATOMIC: dmb {{ish$}} +; CHECK-STRICT-ATOMIC: str +; CHECK-STRICT-ATOMIC: dmb {{ish$}} +; CHECK-STRICT-ATOMIC: ldr ; CHECK-STRICT-ATOMIC: dmb {{ish$}} store atomic i32 %v, i32* %p seq_cst, align 4 @@ -39,6 +44,7 @@ define i32 @test_acq(i32* %addr) { ; CHECK: ldr ; CHECK: dmb {{ish$}} +; CHECK-STRICT-ATOMIC-LABEL: test_acq: ; CHECK-STRICT-ATOMIC: dmb {{ish$}} %val = load atomic i32* %addr acquire, align 4 ret i32 %val