6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-10 18:34:09 +00:00
Code Issues Projects Releases Wiki Activity

[mips] Return {f128} correctly for N32/N64.

Browse Source 
Summary:
According to the ABI documentation, f128 and {f128} should both be returned
in $f0 and $f2. However, this doesn't match GCC's behaviour which is to
return f128 in $f0 and $f2, but {f128} in $f0 and $f1.

Reviewers: vmedic

Reviewed By: vmedic

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D5578

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@219196 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Sanders 2014-10-07 09:29:59 +00:00
parent 95717dbb11
commit 75046b4891
3 changed files with 48 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/Mips/MipsCallingConv.td
View File

@ -29,6 +29,12 @@ def RetCC_F128SoftFloat : CallingConv<[
// pair of i64's.
def RetCC_F128HardFloat : CallingConv<[
CCBitConvertToType<f64>,
// Contrary to the ABI documentation, a struct containing a long double is
// returned in $f0, and $f1 instead of the usual $f0, and $f2. This is to
// match the de facto ABI as implemented by GCC.
CCIfInReg<CCAssignToReg<[D0_64, D1_64]>>,
CCAssignToReg<[D0_64, D2_64]>
]>;

8
lib/Target/Mips/MipsISelLowering.cpp
View File

@ -3496,12 +3496,16 @@ static bool isF128SoftLibCall(const char *CallSym) {
return std::binary_search(LibCalls, End, CallSym, Comp);
}
/// This function returns true if Ty is fp128 or i128 which was originally a
/// fp128.
/// This function returns true if Ty is fp128, {f128} or i128 which was
/// originally a fp128.
static bool originalTypeIsF128(const Type *Ty, const SDNode *CallNode) {
if (Ty->isFP128Ty())
return true;
if (Ty->isStructTy() && Ty->getStructNumElements() == 1 &&
Ty->getStructElementType(0)->isFP128Ty())
return true;
const ExternalSymbolSDNode *ES =
dyn_cast_or_null<const ExternalSymbolSDNode>(CallNode);

36
test/CodeGen/Mips/cconv/return-hard-struct-f128.ll Normal file
View File

@ -0,0 +1,36 @@
; RUN: llc -mtriple=mips64-linux-gnu -relocation-model=static -mattr=-n64,+n32 < %s | FileCheck --check-prefix=ALL --check-prefix=N32 %s
; RUN: llc -mtriple=mips64el-linux-gnu -relocation-model=static -mattr=-n64,+n32 < %s | FileCheck --check-prefix=ALL --check-prefix=N32 %s
; RUN: llc -mtriple=mips64-linux-gnu -relocation-model=static -mattr=-n64,+n64 < %s | FileCheck --check-prefix=ALL --check-prefix=N64 %s
; RUN: llc -mtriple=mips64el-linux-gnu -relocation-model=static -mattr=-n64,+n64 < %s | FileCheck --check-prefix=ALL --check-prefix=N64 %s
; Test return of {fp128} agrees with de-facto N32/N64 ABI.
@struct_fp128 = global {fp128} zeroinitializer
define inreg {fp128} @ret_struct_fp128() nounwind {
entry:
%0 = load volatile {fp128}* @struct_fp128
ret {fp128} %0
}
; ALL-LABEL: ret_struct_fp128:
; O32 generates different IR so we don't test it here. It returns the struct
; indirectly.
; Contrary to the N32/N64 ABI documentation, a struct containing a long double
; is returned in $f0, and $f1 instead of the usual $f0, and $f2. This is to
; match the de facto ABI as implemented by GCC.
; N32-DAG: lui [[R1:\$[0-9]+]], %hi(struct_fp128)
; N32-DAG: ld [[R2:\$[0-9]+]], %lo(struct_fp128)([[R1]])
; N32-DAG: dmtc1 [[R2]], $f0
; N32-DAG: addiu [[R3:\$[0-9]+]], [[R1]], %lo(struct_fp128)
; N32-DAG: ld [[R4:\$[0-9]+]], 8([[R3]])
; N32-DAG: dmtc1 [[R4]], $f1
; N64-DAG: ld [[R1:\$[0-9]+]], %got_disp(struct_fp128)($1)
; N64-DAG: ld [[R2:\$[0-9]+]], 0([[R1]])
; N64-DAG: dmtc1 [[R2]], $f0
; N64-DAG: ld [[R4:\$[0-9]+]], 8([[R1]])
; N64-DAG: dmtc1 [[R4]], $f1