* Verify function prototypes, not just functions with bodies.

* Verify that functions do not take aggregates as arguments.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@13984 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2004-06-03 06:38:43 +00:00
parent 8c4174a0a7
commit 7c277b3a64

View File

@ -112,12 +112,18 @@ namespace { // Anonymous namespace for class
bool doFinalization(Module &M) { bool doFinalization(Module &M) {
// Scan through, checking all of the external function's linkage now... // Scan through, checking all of the external function's linkage now...
for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I) for (Module::iterator I = M.begin(), E = M.end(); I != E; ++I) {
visitGlobalValue(*I); visitGlobalValue(*I);
// Check to make sure function prototypes are okay.
if (I->isExternal()) visitFunction(*I);
}
for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ++I) for (Module::giterator I = M.gbegin(), E = M.gend(); I != E; ++I)
visitGlobalValue(*I); visitGlobalValue(*I);
// If the module is broken, abort at this time. // If the module is broken, abort at this time.
abortIfBroken(); abortIfBroken();
return false; return false;
@ -284,10 +290,14 @@ void Verifier::visitFunction(Function &F) {
// Check that the argument values match the function type for this function... // Check that the argument values match the function type for this function...
unsigned i = 0; unsigned i = 0;
for (Function::aiterator I = F.abegin(), E = F.aend(); I != E; ++I, ++i) for (Function::aiterator I = F.abegin(), E = F.aend(); I != E; ++I, ++i) {
Assert2(I->getType() == FT->getParamType(i), Assert2(I->getType() == FT->getParamType(i),
"Argument value does not match function argument type!", "Argument value does not match function argument type!",
I, FT->getParamType(i)); I, FT->getParamType(i));
// Make sure no aggregates are passed by value.
Assert1(I->getType()->isFirstClassType(),
"Functions cannot take aggregates as arguments by value!", I);
}
if (!F.isExternal()) { if (!F.isExternal()) {
verifySymbolTable(F.getSymbolTable()); verifySymbolTable(F.getSymbolTable());