From 802fe27d3e61646fafa74332756c2fcd8f243fac Mon Sep 17 00:00:00 2001 From: Nick Lewycky Date: Sun, 22 Oct 2006 19:53:27 +0000 Subject: [PATCH] AllocaInst can't return a null pointer. Fixes missed optimization opportunity pointed out by Andrew Lewycky. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@31115 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/PredicateSimplifier.cpp | 6 ++++++ .../PredicateSimplifier/predsimplify.ll | 17 ++++++++++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/Transforms/Scalar/PredicateSimplifier.cpp b/lib/Transforms/Scalar/PredicateSimplifier.cpp index 7e59352d32c..4d86f6aa46c 100644 --- a/lib/Transforms/Scalar/PredicateSimplifier.cpp +++ b/lib/Transforms/Scalar/PredicateSimplifier.cpp @@ -31,6 +31,7 @@ #define DEBUG_TYPE "predsimplify" #include "llvm/Transforms/Scalar.h" #include "llvm/Constants.h" +#include "llvm/DerivedTypes.h" #include "llvm/Instructions.h" #include "llvm/Pass.h" #include "llvm/ADT/Statistic.h" @@ -446,6 +447,7 @@ namespace { void visitBranchInst(BranchInst &BI); void visitSwitchInst(SwitchInst &SI); + void visitAllocaInst(AllocaInst &AI); void visitLoadInst(LoadInst &LI); void visitStoreInst(StoreInst &SI); void visitBinaryOperator(BinaryOperator &BO); @@ -712,6 +714,10 @@ void PredicateSimplifier::Forwards::visitSwitchInst(SwitchInst &SI) { } } +void PredicateSimplifier::Forwards::visitAllocaInst(AllocaInst &AI) { + KP.addNotEqual(Constant::getNullValue(AI.getType()), &AI); +} + void PredicateSimplifier::Forwards::visitLoadInst(LoadInst &LI) { Value *Ptr = LI.getPointerOperand(); KP.addNotEqual(Constant::getNullValue(Ptr->getType()), Ptr); diff --git a/test/Transforms/PredicateSimplifier/predsimplify.ll b/test/Transforms/PredicateSimplifier/predsimplify.ll index 89d5d4ce498..af6cd155a8e 100644 --- a/test/Transforms/PredicateSimplifier/predsimplify.ll +++ b/test/Transforms/PredicateSimplifier/predsimplify.ll @@ -1,5 +1,5 @@ ; RUN: llvm-as < %s | opt -predsimplify -instcombine -simplifycfg | llvm-dis | grep -v declare | not grep fail && -; RUN: llvm-as < %s | opt -predsimplify -instcombine -simplifycfg | llvm-dis | grep -v declare | grep pass | wc -l | grep 3 +; RUN: llvm-as < %s | opt -predsimplify -instcombine -simplifycfg | llvm-dis | grep -v declare | grep -c pass | grep 4 void %test1(int %x) { entry: @@ -149,6 +149,21 @@ return: ret void } +void %test10() { +entry: + %A = alloca int + %B = seteq int* %A, null + br bool %B, label %cond_true, label %cond_false + +cond_true: + call void (...)* %fail ( ) + ret void + +cond_false: + call void (...)* %pass ( ) + ret void +} + void %switch1(int %x) { entry: %A = seteq int %x, 10