6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-28 04:33:05 +00:00
Code Issues Projects Releases Wiki Activity

Remove Attribute::hasAttributes() and make Attribute::hasAttribute() private.

Browse Source 
The Attribute::hasAttributes() is kind of meaningless since an Attribute can
have only one attribute. And we would rather people use the 'operator=='
instead of Attribute::hasAttribute().

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@174026 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bill Wendling 2013-01-31 02:18:19 +00:00
parent a070d2a035
commit 85238aae1a
3 changed files with 9 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/llvm/IR/Attributes.h
View File

@ -107,6 +107,9 @@ private:
Attribute(AttributeImpl *A) : pImpl(A) {}
static Attribute get(LLVMContext &Context, AttrBuilder &B);
/// \brief Return true if the attribute is present.
bool hasAttribute(AttrKind Val) const;
public:
Attribute() : pImpl(0) {}
@ -126,12 +129,6 @@ public:
// Attribute Accessors
//===--------------------------------------------------------------------===//
/// \brief Return true if the attribute is present.
bool hasAttribute(AttrKind Val) const;
/// \brief Return true if attributes exist
bool hasAttributes() const;
/// \brief Return the kind of this attribute.
Constant *getAttributeKind() const;

1
lib/IR/AttributeImpl.h
View File

@ -46,7 +46,6 @@ public:
AttributeImpl(LLVMContext &C, StringRef data);
bool hasAttribute(Attribute::AttrKind A) const;
bool hasAttributes() const;
Constant *getAttributeKind() const { return Kind; }
ArrayRef<Constant*> getAttributeValues() const { return Vals; }

20
lib/IR/Attributes.cpp
View File

@ -82,10 +82,6 @@ bool Attribute::hasAttribute(AttrKind Val) const {
return pImpl && pImpl->hasAttribute(Val);
}
bool Attribute::hasAttributes() const {
return pImpl && pImpl->hasAttributes();
}
Constant *Attribute::getAttributeKind() const {
return pImpl ? pImpl->getAttributeKind() : 0;
}
@ -185,7 +181,7 @@ std::string Attribute::getAsString() const {
}
bool Attribute::operator==(AttrKind K) const {
return pImpl && *pImpl == K;
return (pImpl && *pImpl == K) || (!pImpl && K == None);
}
bool Attribute::operator!=(AttrKind K) const {
return !(*this == K);
@ -226,10 +222,6 @@ bool AttributeImpl::hasAttribute(Attribute::AttrKind A) const {
return (Raw() & getAttrMask(A)) != 0;
}
bool AttributeImpl::hasAttributes() const {
return Raw() != 0;
}
uint64_t AttributeImpl::getAlignment() const {
uint64_t Mask = Raw() & getAttrMask(Attribute::Alignment);
return 1ULL << ((Mask >> 16) - 1);
@ -369,7 +361,7 @@ AttributeSetNode *AttributeSetNode::get(LLVMContext &C,
bool AttributeSetNode::hasAttribute(Attribute::AttrKind Kind) const {
for (SmallVectorImpl<Attribute>::const_iterator I = AttrList.begin(),
E = AttrList.end(); I != E; ++I)
if (I->hasAttribute(Kind))
if (*I == Kind)
return true;
return false;
}
@ -377,7 +369,7 @@ bool AttributeSetNode::hasAttribute(Attribute::AttrKind Kind) const {
unsigned AttributeSetNode::getAlignment() const {
for (SmallVectorImpl<Attribute>::const_iterator I = AttrList.begin(),
E = AttrList.end(); I != E; ++I)
if (I->hasAttribute(Attribute::Alignment))
if (*I == Attribute::Alignment)
return I->getAlignment();
return 0;
}
@ -385,7 +377,7 @@ unsigned AttributeSetNode::getAlignment() const {
unsigned AttributeSetNode::getStackAlignment() const {
for (SmallVectorImpl<Attribute>::const_iterator I = AttrList.begin(),
E = AttrList.end(); I != E; ++I)
if (I->hasAttribute(Attribute::StackAlignment))
if (*I == Attribute::StackAlignment)
return I->getStackAlignment();
return 0;
}
@ -454,7 +446,7 @@ AttributeSet AttributeSet::get(LLVMContext &C,
for (unsigned i = 0, e = Attrs.size(); i != e; ++i) {
assert((!i || Attrs[i-1].first <= Attrs[i].first) &&
"Misordered Attributes list!");
assert(Attrs[i].second.hasAttributes() &&
assert(Attrs[i].second != Attribute::None &&
"Pointless attribute!");
}
#endif
@ -682,7 +674,7 @@ bool AttributeSet::hasAttrSomewhere(Attribute::AttrKind Attr) const {
for (unsigned I = 0, E = pImpl->getNumAttributes(); I != E; ++I)
for (AttributeSetImpl::const_iterator II = pImpl->begin(I),
IE = pImpl->end(I); II != IE; ++II)
if (II->hasAttribute(Attr))
if (*II == Attr)
return true;
return false;