6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-27 13:30:05 +00:00
Code Issues Projects Releases Wiki Activity

Fix generation of 'isa' and 'discriminator' keywords.

Browse Source 
Summary:
There should be a space before each of these two keywords to avoid
generating invalid assembly files.

NOTE: I could not find an obvious maintainers in CODE_OWNERS.TXT, but
      this seems related to debug info.

Reviewers: echristo

CC: llvm-commits

Differential Revision: http://llvm-reviews.chandlerc.com/D2791

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@201359 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Diego Novillo 2014-02-13 20:05:03 +00:00
parent f2df02b355
commit 86dd0f939f
2 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/MC/MCAsmStreamer.cpp
View File

@ -902,9 +902,9 @@ void MCAsmStreamer::EmitDwarfLocDirective(unsigned FileNo, unsigned Line,
} }
if (Isa) if (Isa)
OS << "isa " << Isa; OS << " isa " << Isa;
if (Discriminator) if (Discriminator)
OS << "discriminator " << Discriminator; OS << " discriminator " << Discriminator;
if (IsVerboseAsm) { if (IsVerboseAsm) {
OS.PadToColumn(MAI->getCommentColumn()); OS.PadToColumn(MAI->getCommentColumn());

13
test/MC/AsmParser/directive_loc.s
View File

@ -1,9 +1,18 @@
# RUN: llvm-mc -triple i386-unknown-unknown %s # RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s -check-prefix=FILE
# FIXME: Actually test the output. # RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s -check-prefix=BASIC-LOC-1
# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s -check-prefix=BASIC-LOC-2
# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s -check-prefix=DISCRIMINATOR
# RUN: llvm-mc -triple i386-unknown-unknown %s | FileCheck %s -check-prefix=ISA
.file 1 "hello" .file 1 "hello"
# FILE: .file 1 "hello"
.loc 1 .loc 1
.loc 1 2 .loc 1 2
# BASIC-LOC-1: .loc 1 2 0
.loc 1 2 3 .loc 1 2 3
# BASIC-LOC-2: .loc 1 2 3
.loc 1 2 discriminator 1 .loc 1 2 discriminator 1
# DISCRIMINATOR: 1 2 0 discriminator 1
.loc 1 2 0 isa 3
# ISA: 1 2 0 isa 3
.loc 1 0 .loc 1 0