mirror of
https://github.com/c64scene-ar/llvm-6502.git
synced 2025-01-15 23:31:37 +00:00
Fix a bug in GVN that Duncan noticed, where we potentially need to insert a
pointer bitcast when performing return slot optimization. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@48343 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
parent
200d607b45
commit
8a97fddbc2
@ -1171,8 +1171,12 @@ bool GVN::performCallSlotOptzn(MemCpyInst* cpy, CallInst* C,
|
|||||||
|
|
||||||
// All the checks have passed, so do the transformation.
|
// All the checks have passed, so do the transformation.
|
||||||
for (unsigned i = 0; i < CS.arg_size(); ++i)
|
for (unsigned i = 0; i < CS.arg_size(); ++i)
|
||||||
if (CS.getArgument(i) == cpySrc)
|
if (CS.getArgument(i) == cpySrc) {
|
||||||
|
if (cpySrc->getType() != cpyDest->getType())
|
||||||
|
cpyDest = CastInst::createPointerCast(cpyDest, cpySrc->getType(),
|
||||||
|
cpyDest->getName(), C);
|
||||||
CS.setArgument(i, cpyDest);
|
CS.setArgument(i, cpyDest);
|
||||||
|
}
|
||||||
|
|
||||||
// Drop any cached information about the call, because we may have changed
|
// Drop any cached information about the call, because we may have changed
|
||||||
// its dependence information by changing its parameter.
|
// its dependence information by changing its parameter.
|
||||||
|
19
test/Transforms/GVN/2008-03-13-ReturnSlotBitcast.ll
Normal file
19
test/Transforms/GVN/2008-03-13-ReturnSlotBitcast.ll
Normal file
@ -0,0 +1,19 @@
|
|||||||
|
; RUN: llvm-as < %s | opt -gvn | llvm-dis | not grep {call.*memcpy.}
|
||||||
|
%a = type { i32 }
|
||||||
|
%b = type { float }
|
||||||
|
|
||||||
|
declare void @llvm.memcpy.i32(i8*, i8*, i32, i32) nounwind
|
||||||
|
declare void @g(%a*)
|
||||||
|
|
||||||
|
define float @f() {
|
||||||
|
entry:
|
||||||
|
%a_var = alloca %a
|
||||||
|
%b_var = alloca %b
|
||||||
|
call void @g(%a *%a_var)
|
||||||
|
%a_i8 = bitcast %a* %a_var to i8*
|
||||||
|
%b_i8 = bitcast %b* %b_var to i8*
|
||||||
|
call void @llvm.memcpy.i32(i8* %b_i8, i8* %a_i8, i32 4, i32 4)
|
||||||
|
%tmp1 = getelementptr %b* %b_var, i32 0, i32 0
|
||||||
|
%tmp2 = load float* %tmp1
|
||||||
|
ret float %tmp2
|
||||||
|
}
|
Loading…
x
Reference in New Issue
Block a user