From 8dd0ab074a86ea5eaadfb970323ce133328a2860 Mon Sep 17 00:00:00 2001 From: Bob Wilson Date: Tue, 26 Jan 2010 19:04:37 +0000 Subject: [PATCH] Revert 94484. Re-disable unittests that need RTTI. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94569 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../ExecutionEngine/JIT/JITEventListenerTest.cpp | 2 ++ unittests/ExecutionEngine/JIT/JITTest.cpp | 14 ++++++++++++++ unittests/Makefile.unittest | 6 +----- unittests/VMCore/PassManagerTest.cpp | 5 +++++ 4 files changed, 22 insertions(+), 5 deletions(-) diff --git a/unittests/ExecutionEngine/JIT/JITEventListenerTest.cpp b/unittests/ExecutionEngine/JIT/JITEventListenerTest.cpp index c3bb8589758..a58a0872a4e 100644 --- a/unittests/ExecutionEngine/JIT/JITEventListenerTest.cpp +++ b/unittests/ExecutionEngine/JIT/JITEventListenerTest.cpp @@ -25,6 +25,7 @@ using namespace llvm; int dummy; +#if 0 namespace { struct FunctionEmittedEvent { @@ -237,3 +238,4 @@ testing::Environment* const jit_env = testing::AddGlobalTestEnvironment(new JITEnvironment); } // anonymous namespace +#endif diff --git a/unittests/ExecutionEngine/JIT/JITTest.cpp b/unittests/ExecutionEngine/JIT/JITTest.cpp index 7f75afada1a..bed2d22f1cf 100644 --- a/unittests/ExecutionEngine/JIT/JITTest.cpp +++ b/unittests/ExecutionEngine/JIT/JITTest.cpp @@ -58,6 +58,7 @@ std::string DumpFunction(const Function *F) { return Result; } +#if 0 class RecordingJITMemoryManager : public JITMemoryManager { const OwningPtr Base; public: @@ -178,6 +179,7 @@ public: return Base->endExceptionTable(F, TableStart, TableEnd, FrameRegister); } }; +#endif bool LoadAssemblyInto(Module *M, const char *assembly) { SMDiagnostic Error; @@ -195,11 +197,15 @@ class JITTest : public testing::Test { virtual void SetUp() { M = new Module("
", Context); MP = new ExistingModuleProvider(M); +#if 0 RJMM = new RecordingJITMemoryManager; RJMM->setPoisonMemory(true); +#endif std::string Error; TheJIT.reset(EngineBuilder(MP).setEngineKind(EngineKind::JIT) +#if 0 .setJITMemoryManager(RJMM) +#endif .setErrorStr(&Error).create()); ASSERT_TRUE(TheJIT.get() != NULL) << Error; } @@ -211,7 +217,9 @@ class JITTest : public testing::Test { LLVMContext Context; Module *M; // Owned by MP. ModuleProvider *MP; // Owned by ExecutionEngine. +#if 0 RecordingJITMemoryManager *RJMM; +#endif OwningPtr TheJIT; }; @@ -430,6 +438,7 @@ TEST_F(JITTest, ModuleDeletion) { TheJIT->getPointerToFunction(func); TheJIT->deleteModuleProvider(MP); +#if 0 SmallPtrSet FunctionsDeallocated; for (unsigned i = 0, e = RJMM->deallocateFunctionBodyCalls.size(); i != e; ++i) { @@ -463,6 +472,7 @@ TEST_F(JITTest, ModuleDeletion) { } EXPECT_EQ(RJMM->startExceptionTableCalls.size(), NumTablesDeallocated); +#endif } // ARM and PPC still emit stubs for calls since the target may be too far away @@ -497,14 +507,18 @@ TEST_F(JITTest, NoStubs) { // We should now allocate no more stubs, we have the code to foo // and the existing stub for bar. +#if 0 int stubsBefore = RJMM->stubsAllocated; +#endif Function *func = M->getFunction("main"); TheJIT->getPointerToFunction(func); Function *bar = M->getFunction("bar"); TheJIT->getPointerToFunction(bar); +#if 0 ASSERT_EQ(stubsBefore, RJMM->stubsAllocated); +#endif } #endif // !ARM && !PPC diff --git a/unittests/Makefile.unittest b/unittests/Makefile.unittest index 65638b2a4f6..656f5e2f412 100644 --- a/unittests/Makefile.unittest +++ b/unittests/Makefile.unittest @@ -14,11 +14,7 @@ # Set up variables for building a unit test. ifdef TESTNAME -CXXFLAGS += -DGTEST_HAS_RTTI=0 -# gcc's TR1 header depends on RTTI, so force googletest to use -# its own tuple implementation. When we import googletest >=1.4.0, we -# can drop this line. -CXXFLAGS += -DGTEST_HAS_TR1_TUPLE=0 +REQUIRES_RTTI = 1 include $(LEVEL)/Makefile.common diff --git a/unittests/VMCore/PassManagerTest.cpp b/unittests/VMCore/PassManagerTest.cpp index cb8f9ebb939..092ce3d928b 100644 --- a/unittests/VMCore/PassManagerTest.cpp +++ b/unittests/VMCore/PassManagerTest.cpp @@ -32,6 +32,10 @@ #include "llvm/Assembly/PrintModulePass.h" #include "gtest/gtest.h" +int dummy; + +#if 0 + namespace llvm { namespace { // ND = no deps @@ -525,3 +529,4 @@ namespace llvm { } } +#endif