From 8f493130bb51dea34c49e08aeab161e6a32dfdc6 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Tue, 13 Sep 2005 21:44:28 +0000 Subject: [PATCH] Add a new Record::getValueAsCode method to mirror the other getValueAs* methods. Use it to simplify some code. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@23336 91177308-0d34-0410-b5e6-96231b3b80d8 --- utils/TableGen/CodeGenTarget.cpp | 13 ++----------- utils/TableGen/Record.cpp | 12 ++++++++++++ utils/TableGen/Record.h | 6 ++++++ 3 files changed, 20 insertions(+), 11 deletions(-) diff --git a/utils/TableGen/CodeGenTarget.cpp b/utils/TableGen/CodeGenTarget.cpp index 61e237f1bd9..7c153ece928 100644 --- a/utils/TableGen/CodeGenTarget.cpp +++ b/utils/TableGen/CodeGenTarget.cpp @@ -154,17 +154,8 @@ CodeGenRegisterClass::CodeGenRegisterClass(Record *R) : TheDef(R) { SpillAlignment = R->getValueAsInt("Alignment"); VT = getValueType(R->getValueAsDef("RegType")); - if (CodeInit *CI = dynamic_cast(R->getValueInit("MethodBodies"))) - MethodBodies = CI->getValue(); - else - throw "Expected 'code' fragment for 'MethodBodies' value in register " - "class '" + getName() + "'!"; - - if (CodeInit *CI = dynamic_cast(R->getValueInit("MethodProtos"))) - MethodProtos = CI->getValue(); - else - throw "Expected 'code' fragment for 'MethodProtos' value in register " - "class '" + getName() + "'!"; + MethodBodies = R->getValueAsCode("MethodBodies"); + MethodProtos = R->getValueAsCode("MethodProtos"); ListInit *RegList = R->getValueAsListInit("MemberList"); for (unsigned i = 0, e = RegList->getSize(); i != e; ++i) { diff --git a/utils/TableGen/Record.cpp b/utils/TableGen/Record.cpp index 077476d07bc..c5f05657499 100644 --- a/utils/TableGen/Record.cpp +++ b/utils/TableGen/Record.cpp @@ -773,6 +773,18 @@ DagInit *Record::getValueAsDag(const std::string &FieldName) const { "' does not have a dag initializer!"; } +std::string Record::getValueAsCode(const std::string &FieldName) const { + const RecordVal *R = getValue(FieldName); + if (R == 0 || R->getValue() == 0) + throw "Record `" + getName() + "' does not have a field named `" + + FieldName + "'!\n"; + + if (const CodeInit *CI = dynamic_cast(R->getValue())) + return CI->getValue(); + throw "Record `" + getName() + "', field `" + FieldName + + "' does not have a code initializer!"; +} + void RecordKeeper::dump() const { std::cerr << *this; } diff --git a/utils/TableGen/Record.h b/utils/TableGen/Record.h index 4ca08902cfe..edd875afcec 100644 --- a/utils/TableGen/Record.h +++ b/utils/TableGen/Record.h @@ -1023,6 +1023,12 @@ public: /// the value is not the right type. /// DagInit *getValueAsDag(const std::string &FieldName) const; + + /// getValueAsCode - This method looks up the specified field and returns + /// its value as the string data in a CodeInit, throwing an exception if the + /// field does not exist or if the value is not a code object. + /// + std::string getValueAsCode(const std::string &FieldName) const; }; std::ostream &operator<<(std::ostream &OS, const Record &R);