From 9178a65263bb1f00bb52a53e4e371f62db27d3bb Mon Sep 17 00:00:00 2001 From: Nick Kledzik Date: Tue, 27 May 2008 22:07:08 +0000 Subject: [PATCH] fix infinite recursion if a global's initializer references the global git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51617 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/lto2/LTOModule.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/lto2/LTOModule.cpp b/tools/lto2/LTOModule.cpp index c4bee714c6c..eb0a094934f 100644 --- a/tools/lto2/LTOModule.cpp +++ b/tools/lto2/LTOModule.cpp @@ -161,7 +161,7 @@ void LTOModule::addDefinedDataSymbol(GlobalValue* v, Mangler &mangler) addDefinedSymbol(v, mangler, false); // add external symbols referenced by this data. - for (unsigned count = 0, total = v->getNumOperands();\ + for (unsigned count = 0, total = v->getNumOperands(); count != total; ++count) { findExternalRefs(v->getOperand(count), mangler); } @@ -234,8 +234,13 @@ void LTOModule::findExternalRefs(Value* value, Mangler &mangler) { if (GlobalValue* gv = dyn_cast(value)) { if ( !gv->hasExternalLinkage() ) addPotentialUndefinedSymbol(gv, mangler); + // If this is a variable definition, do not recursively process + // initializer. It might contain a reference to this variable + // and cause an infinite loop. The initializer will be + // processed in addDefinedDataSymbol(). + return; } - + // GlobalValue, even with InternalLinkage type, may have operands with // ExternalLinkage type. Do not ignore these operands. if (Constant* c = dyn_cast(value)) {