Rename canCombinedSubRegIndex method to something more grammatically correct

and tidy up the comment describing it.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@105339 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Bob Wilson
2010-06-02 18:54:47 +00:00
parent 20fae65181
commit 91a74da036
4 changed files with 21 additions and 19 deletions

View File

@@ -469,14 +469,15 @@ public:
return 0; return 0;
} }
/// canCombinedSubRegIndex - Given a register class and a list of sub-register /// canCombineSubRegIndices - Given a register class and a list of
/// indices, return true if it's possible to combine the sub-register indices /// subregister indices, return true if it's possible to combine the
/// into one that corresponds to a larger sub-register. Return the new sub- /// subregister indices into one that corresponds to a larger
/// register index by reference. Note the new index by be zero if the given /// subregister. Return the new subregister index by reference. Note the
/// sub-registers combined to form the whole register. /// new index may be zero if the given subregisters can be combined to
virtual bool canCombinedSubRegIndex(const TargetRegisterClass *RC, /// form the whole register.
SmallVectorImpl<unsigned> &SubIndices, virtual bool canCombineSubRegIndices(const TargetRegisterClass *RC,
unsigned &NewSubIdx) const { SmallVectorImpl<unsigned> &SubIndices,
unsigned &NewSubIdx) const {
return 0; return 0;
} }

View File

@@ -1185,8 +1185,8 @@ TwoAddressInstructionPass::CoalesceExtSubRegs(SmallVector<unsigned,4> &Srcs,
std::sort(SubIndices.begin(), SubIndices.end()); std::sort(SubIndices.begin(), SubIndices.end());
unsigned NewSubIdx = 0; unsigned NewSubIdx = 0;
if (TRI->canCombinedSubRegIndex(MRI->getRegClass(SrcReg), SubIndices, if (TRI->canCombineSubRegIndices(MRI->getRegClass(SrcReg), SubIndices,
NewSubIdx)) { NewSubIdx)) {
bool Proceed = true; bool Proceed = true;
if (NewSubIdx) if (NewSubIdx)
for (MachineRegisterInfo::reg_iterator RI = MRI->reg_begin(SrcReg), for (MachineRegisterInfo::reg_iterator RI = MRI->reg_begin(SrcReg),

View File

@@ -302,7 +302,7 @@ ARMBaseRegisterInfo::getMatchingSuperRegClass(const TargetRegisterClass *A,
} }
bool bool
ARMBaseRegisterInfo::canCombinedSubRegIndex(const TargetRegisterClass *RC, ARMBaseRegisterInfo::canCombineSubRegIndices(const TargetRegisterClass *RC,
SmallVectorImpl<unsigned> &SubIndices, SmallVectorImpl<unsigned> &SubIndices,
unsigned &NewSubIdx) const { unsigned &NewSubIdx) const {

View File

@@ -78,14 +78,15 @@ public:
getMatchingSuperRegClass(const TargetRegisterClass *A, getMatchingSuperRegClass(const TargetRegisterClass *A,
const TargetRegisterClass *B, unsigned Idx) const; const TargetRegisterClass *B, unsigned Idx) const;
/// canCombinedSubRegIndex - Given a register class and a list of sub-register /// canCombineSubRegIndices - Given a register class and a list of
/// indices, return true if it's possible to combine the sub-register indices /// subregister indices, return true if it's possible to combine the
/// into one that corresponds to a larger sub-register. Return the new sub- /// subregister indices into one that corresponds to a larger
/// register index by reference. Note the new index by be zero if the given /// subregister. Return the new subregister index by reference. Note the
/// sub-registers combined to form the whole register. /// new index may be zero if the given subregisters can be combined to
virtual bool canCombinedSubRegIndex(const TargetRegisterClass *RC, /// form the whole register.
SmallVectorImpl<unsigned> &SubIndices, virtual bool canCombineSubRegIndices(const TargetRegisterClass *RC,
unsigned &NewSubIdx) const; SmallVectorImpl<unsigned> &SubIndices,
unsigned &NewSubIdx) const;
const TargetRegisterClass *getPointerRegClass(unsigned Kind = 0) const; const TargetRegisterClass *getPointerRegClass(unsigned Kind = 0) const;