6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-09 10:31:14 +00:00
Code Issues Projects Releases Wiki Activity

rename getOrCreateSlot -> CreateSlotIfNeeded. Noone cares about the retval

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@34125 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2007-02-10 04:54:01 +00:00
parent 17d60ce795
commit 94bec4fbf8
2 changed files with 14 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/Bytecode/Writer/SlotCalculator.cpp
View File

@ -82,21 +82,21 @@ void SlotCalculator::processModule() {
// //
for (Module::const_global_iterator I = TheModule->global_begin(), for (Module::const_global_iterator I = TheModule->global_begin(),
E = TheModule->global_end(); I != E; ++I) E = TheModule->global_end(); I != E; ++I)
getOrCreateSlot(I); CreateSlotIfNeeded(I);
// Scavenge the types out of the functions, then add the functions themselves // Scavenge the types out of the functions, then add the functions themselves
// to the value table... // to the value table...
// //
for (Module::const_iterator I = TheModule->begin(), E = TheModule->end(); for (Module::const_iterator I = TheModule->begin(), E = TheModule->end();
I != E; ++I) I != E; ++I)
getOrCreateSlot(I); CreateSlotIfNeeded(I);
// Add all of the module level constants used as initializers // Add all of the module level constants used as initializers
// //
for (Module::const_global_iterator I = TheModule->global_begin(), for (Module::const_global_iterator I = TheModule->global_begin(),
E = TheModule->global_end(); I != E; ++I) E = TheModule->global_end(); I != E; ++I)
if (I->hasInitializer()) if (I->hasInitializer())
getOrCreateSlot(I->getInitializer()); CreateSlotIfNeeded(I->getInitializer());
// Now that all global constants have been added, rearrange constant planes // Now that all global constants have been added, rearrange constant planes
// that contain constant strings so that the strings occur at the start of the // that contain constant strings so that the strings occur at the start of the
@ -137,7 +137,7 @@ void SlotCalculator::processModule() {
OI != E; ++OI) { OI != E; ++OI) {
if ((isa<Constant>(*OI) && !isa<GlobalValue>(*OI)) || if ((isa<Constant>(*OI) && !isa<GlobalValue>(*OI)) ||
isa<InlineAsm>(*OI)) isa<InlineAsm>(*OI))
getOrCreateSlot(*OI); CreateSlotIfNeeded(*OI);
} }
getOrCreateTypeSlot(I->getType()); getOrCreateTypeSlot(I->getType());
} }
@ -199,7 +199,7 @@ void SlotCalculator::processTypeSymbolTable(const TypeSymbolTable *TST) {
void SlotCalculator::processValueSymbolTable(const ValueSymbolTable *VST) { void SlotCalculator::processValueSymbolTable(const ValueSymbolTable *VST) {
for (ValueSymbolTable::const_iterator VI = VST->begin(), VE = VST->end(); for (ValueSymbolTable::const_iterator VI = VST->begin(), VE = VST->end();
VI != VE; ++VI) VI != VE; ++VI)
getOrCreateSlot(VI->second); CreateSlotIfNeeded(VI->second);
} }
void SlotCalculator::incorporateFunction(const Function *F) { void SlotCalculator::incorporateFunction(const Function *F) {
@ -217,16 +217,16 @@ void SlotCalculator::incorporateFunction(const Function *F) {
// Iterate over function arguments, adding them to the value table... // Iterate over function arguments, adding them to the value table...
for(Function::const_arg_iterator I = F->arg_begin(), E = F->arg_end(); for(Function::const_arg_iterator I = F->arg_begin(), E = F->arg_end();
I != E; ++I) I != E; ++I)
getOrCreateSlot(I); CreateSlotIfNeeded(I);
SC_DEBUG("Inserting Instructions:\n"); SC_DEBUG("Inserting Instructions:\n");
// Add all of the instructions to the type planes... // Add all of the instructions to the type planes...
for (Function::const_iterator BB = F->begin(), E = F->end(); BB != E; ++BB) { for (Function::const_iterator BB = F->begin(), E = F->end(); BB != E; ++BB) {
getOrCreateSlot(BB); CreateSlotIfNeeded(BB);
for (BasicBlock::const_iterator I = BB->begin(), E = BB->end(); I!=E; ++I) { for (BasicBlock::const_iterator I = BB->begin(), E = BB->end(); I!=E; ++I) {
if (I->getType() != Type::VoidTy) if (I->getType() != Type::VoidTy)
getOrCreateSlot(I); CreateSlotIfNeeded(I);
} }
} }
@ -295,9 +295,9 @@ int SlotCalculator::getTypeSlot(const Type*T) const {
return -1; return -1;
} }
int SlotCalculator::getOrCreateSlot(const Value *V) { void SlotCalculator::CreateSlotIfNeeded(const Value *V) {
int SlotNo = getSlot(V); // Check to see if it's already in! // Check to see if it's already in!
if (SlotNo != -1) return SlotNo; if (getSlot(V) != -1) return;
const Type *Ty = V->getType(); const Type *Ty = V->getType();
assert(Ty != Type::VoidTy && "Can't insert void values!"); assert(Ty != Type::VoidTy && "Can't insert void values!");
@ -319,7 +319,7 @@ int SlotCalculator::getOrCreateSlot(const Value *V) {
// const ints), that they are inserted also. // const ints), that they are inserted also.
for (User::const_op_iterator I = C->op_begin(), E = C->op_end(); for (User::const_op_iterator I = C->op_begin(), E = C->op_end();
I != E; ++I) I != E; ++I)
getOrCreateSlot(*I); CreateSlotIfNeeded(*I);
} }
} }
@ -347,12 +347,7 @@ int SlotCalculator::getOrCreateSlot(const Value *V) {
Table[TyPlane].push_back(V); Table[TyPlane].push_back(V);
SC_DEBUG(" Inserting value [" << TyPlane << "] = " << *V << " slot=" << SC_DEBUG(" Inserting value [" << TyPlane << "] = " << *V << " slot=" <<
DestSlot << " ["); DestSlot << "\n");
// G = Global, C = Constant, T = Type, F = Function, o = other
SC_DEBUG((isa<GlobalVariable>(V) ? "G" : (isa<Constant>(V) ? "C" :
(isa<Function>(V) ? "F" : "o"))));
SC_DEBUG("]\n");
return (int)DestSlot;
} }

6
lib/Bytecode/Writer/SlotCalculator.h
View File

@ -104,11 +104,7 @@ public:
string_iterator string_end() const { return ConstantStrings.end(); } string_iterator string_end() const { return ConstantStrings.end(); }
private: private:
// getOrCreateSlot - Values can be crammed into here at will... if void CreateSlotIfNeeded(const Value *V);
// they haven't been inserted already, they get inserted, otherwise
// they are ignored.
//
int getOrCreateSlot(const Value *V);
unsigned getOrCreateTypeSlot(const Type *T); unsigned getOrCreateTypeSlot(const Type *T);
// doInsertValue - Small helper function to be called only be insertVal. // doInsertValue - Small helper function to be called only be insertVal.