6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-13 04:38:24 +00:00
Code Issues Projects Releases Wiki Activity

DebugInfo: Add GNU_addr_base and GNU_ranges_base only when there are addresses or ranges

Browse Source 
Based on code review feedback from Eric in r204672.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204702 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
David Blaikie
2014-03-25 05:34:24 +00:00
parent f50e709043
commit 9d5961d0d8
4 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
lib/CodeGen/AsmPrinter/DwarfDebug.cpp
View File

@ -956,6 +956,17 @@ void DwarfDebug::finalizeModuleInfo() {
dwarf::DW_FORM_data8, ID);
SkCU->addUInt(SkCU->getUnitDie(), dwarf::DW_AT_GNU_dwo_id,
dwarf::DW_FORM_data8, ID);
// We don't keep track of which addresses are used in which CU so this
// is a bit pessimistic under LTO.
if (!InfoHolder.getAddrPool()->empty())
addSectionLabel(Asm, SkCU, SkCU->getUnitDie(),
dwarf::DW_AT_GNU_addr_base, DwarfAddrSectionSym,
DwarfAddrSectionSym);
if (!TheU->getRangeLists().empty())
addSectionLabel(Asm, SkCU, SkCU->getUnitDie(),
dwarf::DW_AT_GNU_ranges_base,
DwarfDebugRangeSectionSym, DwarfDebugRangeSectionSym);
}
// If we have code split among multiple sections or non-contiguous
@ -2660,19 +2671,6 @@ DwarfCompileUnit *DwarfDebug::constructSkeletonCU(const DwarfCompileUnit *CU) {
initSkeletonUnit(CU, Die, NewCU);
// Relocate to the beginning of the addr_base section, else 0 for the
// beginning of the one for this compile unit.
// We could shave off some space if we deferred adding these attributes until
// the end of the CU to see if we have a non-empty debug_addr and debug_ranges
// sections so we don't bother with extra attributes and relocations.
if (Asm->MAI->doesDwarfUseRelocationsAcrossSections()) {
NewCU->addSectionLabel(Die, dwarf::DW_AT_GNU_addr_base, DwarfAddrSectionSym);
NewCU->addSectionLabel(Die, dwarf::DW_AT_GNU_ranges_base, DwarfDebugRangeSectionSym);
} else {
NewCU->addSectionOffset(Die, dwarf::DW_AT_GNU_addr_base, 0);
NewCU->addSectionOffset(Die, dwarf::DW_AT_GNU_ranges_base, 0);
}
return NewCU;
}