6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-05-18 06:38:41 +00:00
Code Issues Projects Releases Wiki Activity

MC/X86: Error out if we see a non-constant FK_Data_1 or FK_Data_2 fixup, since

Browse Source 
we don't currently support relaxing them.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@103195 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Dunbar 2010-05-06 20:34:01 +00:00
parent 34dcc6fadc
commit a5d0b54ec1
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/Target/X86/X86AsmBackend.cpp
View File

@ -12,6 +12,7 @@
#include "X86FixupKinds.h" #include "X86FixupKinds.h"
#include "llvm/ADT/Twine.h" #include "llvm/ADT/Twine.h"
#include "llvm/MC/MCAssembler.h" #include "llvm/MC/MCAssembler.h"
#include "llvm/MC/MCExpr.h"
#include "llvm/MC/MCObjectWriter.h" #include "llvm/MC/MCObjectWriter.h"
#include "llvm/MC/MCSectionELF.h" #include "llvm/MC/MCSectionELF.h"
#include "llvm/MC/MCSectionMachO.h" #include "llvm/MC/MCSectionMachO.h"
@ -88,9 +89,20 @@ static unsigned getRelaxedOpcode(unsigned Op) {
bool X86AsmBackend::MayNeedRelaxation(const MCInst &Inst, bool X86AsmBackend::MayNeedRelaxation(const MCInst &Inst,
const SmallVectorImpl<MCAsmFixup> &Fixups) const { const SmallVectorImpl<MCAsmFixup> &Fixups) const {
// Check for a 1byte pcrel fixup, and enforce that we would know how to relax
// this instruction.
for (unsigned i = 0, e = Fixups.size(); i != e; ++i) { for (unsigned i = 0, e = Fixups.size(); i != e; ++i) {
// We don't support relaxing anything else currently. Make sure we error out
// if we see a non-constant 1 or 2 byte fixup.
//
// FIXME: We should need to check this here, this is better checked in the
// object writer which should be verifying that any final relocations match
// the expected fixup. However, that code is more complicated and hasn't
// been written yet. See the FIXMEs in MachObjectWriter.cpp.
if ((Fixups[i].Kind == FK_Data_1 || Fixups[i].Kind == FK_Data_2) &&
!isa<MCConstantExpr>(Fixups[i].Value))
report_fatal_error("unexpected small fixup with a non-constant operand!");
// Check for a 1byte pcrel fixup, and enforce that we would know how to
// relax this instruction.
if (unsigned(Fixups[i].Kind) == X86::reloc_pcrel_1byte) { if (unsigned(Fixups[i].Kind) == X86::reloc_pcrel_1byte) {
assert(getRelaxedOpcode(Inst.getOpcode()) != Inst.getOpcode()); assert(getRelaxedOpcode(Inst.getOpcode()) != Inst.getOpcode());
return true; return true;