6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-21 21:29:41 +00:00
Code Issues Projects Releases Wiki Activity

PR10991: make fast-isel correctly check whether accessing a global through an alias involves thread-local storage. (I'm not entirely sure how this is supposed to work, but this patch makes fast-isel consistent with the normal isel path.)

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@140355 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Eli Friedman 2011-09-22 23:41:28 +00:00
parent 40eda4626d
commit a6176adc8a
2 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/Target/X86/X86FastISel.cpp
View File

@ -22,6 +22,7 @@
#include "llvm/CallingConv.h" #include "llvm/CallingConv.h"
#include "llvm/DerivedTypes.h" #include "llvm/DerivedTypes.h"
#include "llvm/GlobalVariable.h" #include "llvm/GlobalVariable.h"
#include "llvm/GlobalAlias.h"
#include "llvm/Instructions.h" #include "llvm/Instructions.h"
#include "llvm/IntrinsicInst.h" #include "llvm/IntrinsicInst.h"
#include "llvm/Operator.h" #include "llvm/Operator.h"
@ -467,14 +468,23 @@ bool X86FastISel::X86SelectAddress(const Value *V, X86AddressMode &AM) {
// Handle constant address. // Handle constant address.
if (const GlobalValue *GV = dyn_cast<GlobalValue>(V)) { if (const GlobalValue *GV = dyn_cast<GlobalValue>(V)) {
// Can't handle alternate code models or TLS yet. // Can't handle alternate code models yet.
if (TM.getCodeModel() != CodeModel::Small) if (TM.getCodeModel() != CodeModel::Small)
return false; return false;
// Can't handle TLS yet.
if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV)) if (const GlobalVariable *GVar = dyn_cast<GlobalVariable>(GV))
if (GVar->isThreadLocal()) if (GVar->isThreadLocal())
return false; return false;
// Can't handle TLS yet, part 2 (this is slightly crazy, but this is how
// it works...).
if (const GlobalAlias *GA = dyn_cast<GlobalAlias>(GV))
if (const GlobalVariable *GVar =
dyn_cast_or_null<GlobalVariable>(GA->resolveAliasedGlobal(false)))
if (GVar->isThreadLocal())
return false;
// RIP-relative addresses can't have additional register operands, so if // RIP-relative addresses can't have additional register operands, so if
// we've already folded stuff into the addressing mode, just force the // we've already folded stuff into the addressing mode, just force the
// global value into its own register, which we can use as the basereg. // global value into its own register, which we can use as the basereg.

18
test/CodeGen/X86/fast-isel-tls.ll
View File

@ -1,4 +1,4 @@
; RUN: llc < %s -march=x86 -relocation-model=pic -mtriple=i686-unknown-linux-gnu -fast-isel | grep __tls_get_addr ; RUN: llc < %s -march=x86 -relocation-model=pic -mtriple=i686-unknown-linux-gnu -fast-isel | FileCheck %s
; PR3654 ; PR3654
@v = thread_local global i32 0 @v = thread_local global i32 0
@ -8,3 +8,19 @@ entry:
%s = add i32 %t, 1 %s = add i32 %t, 1
ret i32 %s ret i32 %s
} }
; CHECK: f:
; CHECK: leal v@TLSGD
; CHECK: __tls_get_addr
@alias = alias internal i32* @v
define i32 @f_alias() nounwind {
entry:
%t = load i32* @v
%s = add i32 %t, 1
ret i32 %s
}
; CHECK: f_alias:
; CHECK: leal v@TLSGD
; CHECK: __tls_get_addr