6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-03-03 14:31:10 +00:00
Code Issues Projects Releases Wiki Activity

Don't use DominatorSet::dominates for intra-block instruction dom checks.

Browse Source 
This method is linear time in the size of the basic block, which is very
bad for large basic blocks.  On the Assembler/2004-09-29-VerifierIsReallySlow.llx
testcase, the verifier changes from taking 50s to 0.23s with this patch.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@16593 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2004-09-29 20:07:45 +00:00
parent 1b2f90d2c0
commit a7b1c7ec7c
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/VMCore/Verifier.cpp
View File

@ -70,6 +70,12 @@ namespace { // Anonymous namespace for class
DominatorSet *DS; // Dominator set, caution can be null!
std::stringstream msgs; // A stringstream to collect messages
/// InstInThisBlock - when verifying a basic block, keep track of all of the
/// instructions we have seen so far. This allows us to do efficient
/// dominance checks for the case when an instruction has an operand that is
/// an instruction in the same block.
std::set<Instruction*> InstsInThisBlock;
Verifier()
: Broken(false), RealPass(true), action(AbortProcessAction),
DS(0), msgs( std::ios_base::app | std::ios_base::out ) {}
@ -101,6 +107,7 @@ namespace { // Anonymous namespace for class
// Get dominator information if we are being run by PassManager
if (RealPass) DS = &getAnalysis<DominatorSet>();
visit(F);
InstsInThisBlock.clear();
// If this is a real pass, in a pass manager, we must abort before
// returning back to the pass manager, or else the pass manager may try to
@ -312,6 +319,8 @@ void Verifier::visitFunction(Function &F) {
// verifyBasicBlock - Verify that a basic block is well formed...
//
void Verifier::visitBasicBlock(BasicBlock &BB) {
InstsInThisBlock.clear();
// Check constraints that this basic block imposes on all of the PHI nodes in
// it.
if (isa<PHINode>(BB.front())) {
@ -592,7 +601,7 @@ void Verifier::visitInstruction(Instruction &I) {
else if (OpBlock == BB) {
// If they are in the same basic block, make sure that the definition
// comes before the use.
Assert2(DS->dominates(Op, &I) ||
Assert2(InstsInThisBlock.count(Op) ||
!DS->dominates(&BB->getParent()->getEntryBlock(), BB),
"Instruction does not dominate all uses!", Op, &I);
}
@ -611,6 +620,7 @@ void Verifier::visitInstruction(Instruction &I) {
}
}
}
InstsInThisBlock.insert(&I);
}
/// visitIntrinsicFunction - Allow intrinsics to be verified in different ways.