From aad181f64485fbc75ce02b7dc993004d3aa168c2 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Sun, 18 May 2014 15:14:13 +0000 Subject: [PATCH] Options: Use erase_if to remove Args from the list. While there make getOption return a const reference so we don't have to put it on the stack when calling methods on it. No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@209088 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Option/Arg.h | 2 +- lib/Option/ArgList.cpp | 11 +++-------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/include/llvm/Option/Arg.h b/include/llvm/Option/Arg.h index d1e1aa1ce73..dcaa5405ba7 100644 --- a/include/llvm/Option/Arg.h +++ b/include/llvm/Option/Arg.h @@ -67,7 +67,7 @@ public: const char *Value0, const char *Value1, const Arg *BaseArg = nullptr); ~Arg(); - const Option getOption() const { return Opt; } + const Option &getOption() const { return Opt; } StringRef getSpelling() const { return Spelling; } unsigned getIndex() const { return Index; } diff --git a/lib/Option/ArgList.cpp b/lib/Option/ArgList.cpp index 1f16331e079..a5ab8d747d8 100644 --- a/lib/Option/ArgList.cpp +++ b/lib/Option/ArgList.cpp @@ -41,14 +41,9 @@ void ArgList::append(Arg *A) { } void ArgList::eraseArg(OptSpecifier Id) { - for (iterator it = begin(), ie = end(); it != ie; ) { - if ((*it)->getOption().matches(Id)) { - it = Args.erase(it); - ie = end(); - } else { - ++it; - } - } + Args.erase(std::remove_if(begin(), end(), + [=](Arg *A) { return A->getOption().matches(Id); }), + end()); } Arg *ArgList::getLastArgNoClaim(OptSpecifier Id) const {