BitstreamWriter: Change primary output buffer to be a SmallVector instead of an

std::vector.
 - Good for 1-2% speedup on writing PCH for Cocoa.h.
 - Clang side API match to follow shortly, there wasn't an easy way to make this
   non-breaking.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@151750 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Daniel Dunbar
2012-02-29 20:31:09 +00:00
parent a8d16bbdfb
commit acbceeae4d
2 changed files with 6 additions and 6 deletions

View File

@@ -16,13 +16,14 @@
#define BITSTREAM_WRITER_H #define BITSTREAM_WRITER_H
#include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringRef.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/Bitcode/BitCodes.h" #include "llvm/Bitcode/BitCodes.h"
#include <vector> #include <vector>
namespace llvm { namespace llvm {
class BitstreamWriter { class BitstreamWriter {
std::vector<unsigned char> &Out; SmallVectorImpl<char> &Out;
/// CurBit - Always between 0 and 31 inclusive, specifies the next bit to use. /// CurBit - Always between 0 and 31 inclusive, specifies the next bit to use.
unsigned CurBit; unsigned CurBit;
@@ -90,7 +91,7 @@ class BitstreamWriter {
} }
public: public:
explicit BitstreamWriter(std::vector<unsigned char> &O) explicit BitstreamWriter(SmallVectorImpl<char> &O)
: Out(O), CurBit(0), CurValue(0), CurCodeSize(2) {} : Out(O), CurBit(0), CurValue(0), CurCodeSize(2) {}
~BitstreamWriter() { ~BitstreamWriter() {

View File

@@ -1774,8 +1774,7 @@ enum {
DarwinBCHeaderSize = 5*4 DarwinBCHeaderSize = 5*4
}; };
static void WriteInt32ToBuffer(uint32_t Value, static void WriteInt32ToBuffer(uint32_t Value, SmallVectorImpl<char> &Buffer,
std::vector<unsigned char> &Buffer,
uint32_t &Position) { uint32_t &Position) {
Buffer[Position + 0] = (unsigned char) (Value >> 0); Buffer[Position + 0] = (unsigned char) (Value >> 0);
Buffer[Position + 1] = (unsigned char) (Value >> 8); Buffer[Position + 1] = (unsigned char) (Value >> 8);
@@ -1784,7 +1783,7 @@ static void WriteInt32ToBuffer(uint32_t Value,
Position += 4; Position += 4;
} }
static void EmitDarwinBCHeaderAndTrailer(std::vector<unsigned char> &Buffer, static void EmitDarwinBCHeaderAndTrailer(SmallVectorImpl<char> &Buffer,
const Triple &TT) { const Triple &TT) {
unsigned CPUType = ~0U; unsigned CPUType = ~0U;
@@ -1833,7 +1832,7 @@ static void EmitDarwinBCHeaderAndTrailer(std::vector<unsigned char> &Buffer,
/// WriteBitcodeToFile - Write the specified module to the specified output /// WriteBitcodeToFile - Write the specified module to the specified output
/// stream. /// stream.
void llvm::WriteBitcodeToFile(const Module *M, raw_ostream &Out) { void llvm::WriteBitcodeToFile(const Module *M, raw_ostream &Out) {
std::vector<unsigned char> Buffer; SmallVector<char, 1024> Buffer;
Buffer.reserve(256*1024); Buffer.reserve(256*1024);
// If this is darwin or another generic macho target, reserve space for the // If this is darwin or another generic macho target, reserve space for the