diff --git a/include/llvm/Target/DarwinTargetAsmInfo.h b/include/llvm/Target/DarwinTargetAsmInfo.h index 0834390600f..2b5bf7c9314 100644 --- a/include/llvm/Target/DarwinTargetAsmInfo.h +++ b/include/llvm/Target/DarwinTargetAsmInfo.h @@ -20,11 +20,12 @@ namespace llvm { class GlobalValue; class GlobalVariable; + class Triple; class Type; class Mangler; struct DarwinTargetAsmInfo : public TargetAsmInfo { - explicit DarwinTargetAsmInfo(); + explicit DarwinTargetAsmInfo(const Triple &Triple); }; } diff --git a/lib/Target/ARM/ARMTargetAsmInfo.cpp b/lib/Target/ARM/ARMTargetAsmInfo.cpp index 0c3df82bfe2..b3aa3bd9d51 100644 --- a/lib/Target/ARM/ARMTargetAsmInfo.cpp +++ b/lib/Target/ARM/ARMTargetAsmInfo.cpp @@ -40,7 +40,8 @@ static const char *const arm_asm_table[] = { 0,0 }; -ARMDarwinTargetAsmInfo::ARMDarwinTargetAsmInfo() { +ARMDarwinTargetAsmInfo::ARMDarwinTargetAsmInfo(const Triple &Triple) + : DarwinTargetAsmInfo(Triple) { AsmTransCBE = arm_asm_table; Data64bitsDirective = 0; CommentString = "@"; diff --git a/lib/Target/ARM/ARMTargetAsmInfo.h b/lib/Target/ARM/ARMTargetAsmInfo.h index 3fde8ba6307..745f3c6ceac 100644 --- a/lib/Target/ARM/ARMTargetAsmInfo.h +++ b/lib/Target/ARM/ARMTargetAsmInfo.h @@ -19,7 +19,7 @@ namespace llvm { struct ARMDarwinTargetAsmInfo : public DarwinTargetAsmInfo { - explicit ARMDarwinTargetAsmInfo(); + explicit ARMDarwinTargetAsmInfo(const Triple &Triple); }; struct ARMELFTargetAsmInfo : public TargetAsmInfo { diff --git a/lib/Target/ARM/ARMTargetMachine.cpp b/lib/Target/ARM/ARMTargetMachine.cpp index fbc5f38efea..1198aa94b56 100644 --- a/lib/Target/ARM/ARMTargetMachine.cpp +++ b/lib/Target/ARM/ARMTargetMachine.cpp @@ -32,7 +32,7 @@ static const TargetAsmInfo *createTargetAsmInfo(const Target &T, Triple TheTriple(TT); switch (TheTriple.getOS()) { case Triple::Darwin: - return new ARMDarwinTargetAsmInfo(); + return new ARMDarwinTargetAsmInfo(TheTriple); default: return new ARMELFTargetAsmInfo(); } diff --git a/lib/Target/DarwinTargetAsmInfo.cpp b/lib/Target/DarwinTargetAsmInfo.cpp index c37b41b7001..a37bf18a97a 100644 --- a/lib/Target/DarwinTargetAsmInfo.cpp +++ b/lib/Target/DarwinTargetAsmInfo.cpp @@ -13,9 +13,10 @@ //===----------------------------------------------------------------------===// #include "llvm/Target/DarwinTargetAsmInfo.h" +#include "llvm/ADT/Triple.h" using namespace llvm; -DarwinTargetAsmInfo::DarwinTargetAsmInfo() { +DarwinTargetAsmInfo::DarwinTargetAsmInfo(const Triple &Triple) { // Common settings for all Darwin targets. // Syntax: GlobalPrefix = "_"; @@ -47,13 +48,16 @@ DarwinTargetAsmInfo::DarwinTargetAsmInfo() { HasDotTypeDotSizeDirective = false; UsedDirective = "\t.no_dead_strip\t"; - // _foo.eh symbols are currently always exported so that the linker knows - // about them. This is not necessary on 10.6 and later, but it - // doesn't hurt anything. - // FIXME: I need to get this from Triple. - Is_EHSymbolPrivate = false; + // On Leoaprd (10.5 aka darwin9) and earlier, _foo.eh symbols must be exported + // so that the linker knows about them. This is not necessary on 10.6 and + // later, but it doesn't hurt anything. + if (Triple.getDarwinMajorNumber() >= 10) + Is_EHSymbolPrivate = false; + + // Leopard (10.5 aka darwin9) and later support aligned common symbols. + COMMDirectiveTakesAlignment = Triple.getDarwinMajorNumber() >= 9; + GlobalEHDirective = "\t.globl\t"; SupportsWeakOmittedEHFrame = false; - } diff --git a/lib/Target/PowerPC/PPCTargetAsmInfo.cpp b/lib/Target/PowerPC/PPCTargetAsmInfo.cpp index 36cf2a5570d..25920da0fe9 100644 --- a/lib/Target/PowerPC/PPCTargetAsmInfo.cpp +++ b/lib/Target/PowerPC/PPCTargetAsmInfo.cpp @@ -12,19 +12,21 @@ //===----------------------------------------------------------------------===// #include "PPCTargetAsmInfo.h" +#include "llvm/ADT/Triple.h" using namespace llvm; -PPCDarwinTargetAsmInfo::PPCDarwinTargetAsmInfo(bool is64Bit) { +PPCDarwinTargetAsmInfo::PPCDarwinTargetAsmInfo(const Triple &TheTriple) + : DarwinTargetAsmInfo(TheTriple) { PCSymbol = "."; CommentString = ";"; ExceptionsType = ExceptionHandling::Dwarf; - if (!is64Bit) + if (TheTriple.getArch() != Triple::ppc64) Data64bitsDirective = 0; // We can't emit a 64-bit unit in PPC32 mode. AssemblerDialect = 1; // New-Style mnemonics. } -PPCLinuxTargetAsmInfo::PPCLinuxTargetAsmInfo(bool is64Bit) { +PPCLinuxTargetAsmInfo::PPCLinuxTargetAsmInfo(const Triple &TheTriple) { CommentString = "#"; GlobalPrefix = ""; PrivateGlobalPrefix = ".L"; @@ -41,13 +43,15 @@ PPCLinuxTargetAsmInfo::PPCLinuxTargetAsmInfo(bool is64Bit) { HasLEB128 = true; // Target asm supports leb128 directives (little-endian) // Exceptions handling - if (!is64Bit) + if (TheTriple.getArch() != Triple::ppc64) { ExceptionsType = ExceptionHandling::Dwarf; + Data64bitsDirective = 0; + } AbsoluteEHSectionOffsets = false; ZeroDirective = "\t.space\t"; SetDirective = "\t.set"; - Data64bitsDirective = is64Bit ? "\t.quad\t" : 0; + AlignmentIsInBytes = false; LCOMMDirective = "\t.lcomm\t"; AssemblerDialect = 0; // Old-Style mnemonics. diff --git a/lib/Target/PowerPC/PPCTargetAsmInfo.h b/lib/Target/PowerPC/PPCTargetAsmInfo.h index c7f8862e7ff..1e7e3d3745b 100644 --- a/lib/Target/PowerPC/PPCTargetAsmInfo.h +++ b/lib/Target/PowerPC/PPCTargetAsmInfo.h @@ -14,17 +14,16 @@ #ifndef PPCTARGETASMINFO_H #define PPCTARGETASMINFO_H -#include "llvm/Target/TargetAsmInfo.h" #include "llvm/Target/DarwinTargetAsmInfo.h" namespace llvm { struct PPCDarwinTargetAsmInfo : public DarwinTargetAsmInfo { - explicit PPCDarwinTargetAsmInfo(bool is64Bit); + explicit PPCDarwinTargetAsmInfo(const Triple &TheTriple); }; struct PPCLinuxTargetAsmInfo : public TargetAsmInfo { - explicit PPCLinuxTargetAsmInfo(bool is64Bit); + explicit PPCLinuxTargetAsmInfo(const Triple &TheTriple); }; } // namespace llvm diff --git a/lib/Target/PowerPC/PPCTargetMachine.cpp b/lib/Target/PowerPC/PPCTargetMachine.cpp index 41f4699fc06..a0d4fdb776b 100644 --- a/lib/Target/PowerPC/PPCTargetMachine.cpp +++ b/lib/Target/PowerPC/PPCTargetMachine.cpp @@ -23,10 +23,9 @@ using namespace llvm; static const TargetAsmInfo *createTargetAsmInfo(const Target &T, const StringRef &TT) { Triple TheTriple(TT); - bool isPPC64 = TheTriple.getArch() == Triple::ppc64; if (TheTriple.getOS() == Triple::Darwin) - return new PPCDarwinTargetAsmInfo(isPPC64); - return new PPCLinuxTargetAsmInfo(isPPC64); + return new PPCDarwinTargetAsmInfo(TheTriple); + return new PPCLinuxTargetAsmInfo(TheTriple); } diff --git a/lib/Target/X86/X86TargetAsmInfo.cpp b/lib/Target/X86/X86TargetAsmInfo.cpp index d978eb179de..b6270108da2 100644 --- a/lib/Target/X86/X86TargetAsmInfo.cpp +++ b/lib/Target/X86/X86TargetAsmInfo.cpp @@ -43,7 +43,8 @@ static const char *const x86_asm_table[] = { "{cc}", "cc", 0,0}; -X86DarwinTargetAsmInfo::X86DarwinTargetAsmInfo(const Triple &Triple) { +X86DarwinTargetAsmInfo::X86DarwinTargetAsmInfo(const Triple &Triple) + : DarwinTargetAsmInfo(Triple) { AsmTransCBE = x86_asm_table; AssemblerDialect = AsmWriterFlavor; @@ -54,9 +55,6 @@ X86DarwinTargetAsmInfo::X86DarwinTargetAsmInfo(const Triple &Triple) { if (!is64Bit) Data64bitsDirective = 0; // we can't emit a 64-bit unit - // Leopard and above support aligned common symbols. - COMMDirectiveTakesAlignment = Triple.getDarwinMajorNumber() >= 9; - if (is64Bit) { PersonalityPrefix = ""; PersonalitySuffix = "+4@GOTPCREL"; diff --git a/lib/Target/X86/X86TargetAsmInfo.h b/lib/Target/X86/X86TargetAsmInfo.h index 91de3682591..592d5e3396d 100644 --- a/lib/Target/X86/X86TargetAsmInfo.h +++ b/lib/Target/X86/X86TargetAsmInfo.h @@ -19,8 +19,6 @@ #include "llvm/Target/DarwinTargetAsmInfo.h" namespace llvm { - class Triple; - struct X86DarwinTargetAsmInfo : public DarwinTargetAsmInfo { explicit X86DarwinTargetAsmInfo(const Triple &Triple); };