6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-09-28 23:17:10 +00:00
Code Issues Projects Releases Wiki Activity

Per code review:

Browse Source 
* Clean up the StatusInfo constructor to construct all members and give
  them reasonable values.
* Get rid of the Vector typedef and make the interface to
  getDirectoryContent use a std::set instead of a std::vector so the dir
  content is sorted.
* Make the getStatusInfo method const and not return a useless boolean.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@17872 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Reid Spencer
2004-11-16 06:15:19 +00:00
parent 9bbba09139
commit b608a81a18
3 changed files with 15 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/System/Unix/Path.cpp
View File

@@ -239,10 +239,8 @@ Path::getLast() const {
return path.substr(pos+1);
}
bool
Path::getStatusInfo(StatusInfo& info) {
if (!isFile() || !readable())
return false;
void
Path::getStatusInfo(StatusInfo& info) const {
struct stat buf;
if (0 != stat(path.c_str(), &buf)) {
ThrowErrno(std::string("Can't get status: ")+path);
@@ -255,11 +253,10 @@ Path::getStatusInfo(StatusInfo& info) {
info.isDir = S_ISDIR(buf.st_mode);
if (info.isDir && path[path.length()-1] != '/')
path += '/';
return true;
}
bool
Path::getDirectoryContents(Vector& result) const {
Path::getDirectoryContents(std::set<Path>& result) const {
if (!isDirectory())
return false;
DIR* direntries = ::opendir(path.c_str());
@@ -276,7 +273,7 @@ Path::getDirectoryContents(Vector& result) const {
ThrowErrno(aPath.path + ": can't get status");
if (S_ISDIR(buf.st_mode))
aPath.path += "/";
result.push_back(aPath);
result.insert(aPath);
}
de = ::readdir(direntries);
}