diff --git a/lib/Analysis/IPA/CallGraphSCCPass.cpp b/lib/Analysis/IPA/CallGraphSCCPass.cpp index c27edbfa2ff..665aa7f046e 100644 --- a/lib/Analysis/IPA/CallGraphSCCPass.cpp +++ b/lib/Analysis/IPA/CallGraphSCCPass.cpp @@ -243,7 +243,14 @@ bool CGPassManager::RefreshCallGraph(CallGraphSCC &CurSCC, assert(!CallSites.count(I->first) && "Call site occurs in node multiple times"); - CallSites.insert(std::make_pair(I->first, I->second)); + + CallSite CS(I->first); + if (CS) { + Function *Callee = CS.getCalledFunction(); + // Ignore intrinsics because they're not really function calls. + if (!Callee || !(Callee->isIntrinsic())) + CallSites.insert(std::make_pair(I->first, I->second)); + } ++I; } diff --git a/test/Transforms/InstCombine/no_cgscc_assert.ll b/test/Transforms/InstCombine/no_cgscc_assert.ll new file mode 100644 index 00000000000..cec5297695b --- /dev/null +++ b/test/Transforms/InstCombine/no_cgscc_assert.ll @@ -0,0 +1,19 @@ +; RUN: opt < %s -inline -instcombine -S | FileCheck %s + +; PR21403: http://llvm.org/bugs/show_bug.cgi?id=21403 +; When the call to sqrtf is replaced by an intrinsic call to fabs, +; it should not cause a problem in CGSCC. + +define float @bar(float %f) #0 { + %mul = fmul fast float %f, %f + %call1 = call float @sqrtf(float %mul) #0 + ret float %call1 + +; CHECK-LABEL: @bar( +; CHECK-NEXT: call float @llvm.fabs.f32 +; CHECK-NEXT: ret float +} + +declare float @sqrtf(float) #0 + +attributes #0 = { readnone "unsafe-fp-math"="true" }