6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-03-04 05:31:51 +00:00
Code Issues Projects Releases Wiki Activity

Don't define our own global 'endl' variable. While technically it had

Browse Source 
internal linkage and so wasn't a patent bug, it doesn't make any sense
here. We can avoid even calling operator<< by just embedding the newline
in the string literals that were already being streamed out. It also
gives the impression of some line-ending agnosticisms which is not
present, and that flushing happens when it doesn't.

If we want to use std::endl, we could do that, but honestly it doesn't
seem remotely worth it. Using '\n' directly is much more clear when
working with raw_ostream.

It also happens to fix builds with old crufty GCC STL implementations
that include std::endl into the global namespace (or headers written to
be compatible with such atrocities).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179003 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2013-04-08 08:30:47 +00:00
parent 7fba6cd3d0
commit bcff69a1e0
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/obj2yaml/obj2yaml.cpp
View File

@ -16,8 +16,6 @@
#include "llvm/Support/PrettyStackTrace.h" #include "llvm/Support/PrettyStackTrace.h"
#include "llvm/Support/Signals.h" #include "llvm/Support/Signals.h"
const char endl = '\n';
namespace yaml { // generic yaml-writing specific routines namespace yaml { // generic yaml-writing specific routines
unsigned char printable(unsigned char Ch) { unsigned char printable(unsigned char Ch) {
@ -37,7 +35,7 @@ llvm::raw_ostream &writeHexStream(llvm::raw_ostream &Out,
Out << "\" # |"; Out << "\" # |";
for (iter_t iter = arr.begin(); iter != end; ++iter) for (iter_t iter = arr.begin(); iter != end; ++iter)
Out << printable(*iter); Out << printable(*iter);
Out << "|" << endl; Out << "|\n";
return Out; return Out;
} }
@ -75,11 +73,11 @@ int main(int argc, char * argv[]) {
// TODO: If this is an archive, then burst it and dump each entry // TODO: If this is an archive, then burst it and dump each entry
if (error_code ec = MemoryBuffer::getFileOrSTDIN(InputFilename, buf)) if (error_code ec = MemoryBuffer::getFileOrSTDIN(InputFilename, buf))
llvm::errs() << "Error: '" << ec.message() << "' opening file '" llvm::errs() << "Error: '" << ec.message() << "' opening file '"
<< InputFilename << "'" << endl; << InputFilename << "'\n";
else { else {
ec = coff2yaml(llvm::outs(), buf.take()); ec = coff2yaml(llvm::outs(), buf.take());
if (ec) if (ec)
llvm::errs() << "Error: " << ec.message() << " dumping COFF file" << endl; llvm::errs() << "Error: " << ec.message() << " dumping COFF file\n";
} }
return 0; return 0;