6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-01-01 00:33:09 +00:00
Code Issues Projects Releases Wiki Activity

Chris's constant data sequence refactoring actually enabled printing

Browse Source 
vectors of all one bits to be printed more cleverly in the AsmPrinter.
Unfortunately, the byte value for all one bits is the same with
-fsigned-char as the error return of '-1'. Force this to be the unsigned
byte value when returning it to avoid this problem, and update the test
case for the shiny new behavior.

Yay for building LLVM and Clang with -funsigned-char.

Chris, please review, and let me know if there is any reason to not
desire this change. It seems good on the surface, and certainly intended
based on the code written.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@149299 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chandler Carruth 2012-01-30 23:47:44 +00:00
parent 893a045cdb
commit beb05952ce
2 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/CodeGen/AsmPrinter/AsmPrinter.cpp
View File

@ -1558,7 +1558,7 @@ static int isRepeatedByteSequence(const ConstantDataSequential *V) {
char C = Data[0];
for (unsigned i = 1, e = Data.size(); i != e; ++i)
if (Data[i] != C) return -1;
return C;
return static_cast<uint8_t>(C); // Ensure 255 is not returned as -1.
}

5
test/CodeGen/X86/fold-pcmpeqd-2.ll
View File

@ -8,10 +8,7 @@
; RAGreedy defeats the test by splitting live ranges.
; Constant pool all-ones vector:
; CHECK: .long 4294967295
; CHECK-NEXT: .long 4294967295
; CHECK-NEXT: .long 4294967295
; CHECK-NEXT: .long 4294967295
; CHECK: .space 16,255
; No pcmpeqd instructions, everybody uses the constant pool.
; CHECK: program_1: