From c1317939045d1907f1e4a20315feceb0afa384a2 Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Sat, 14 Mar 2009 17:09:17 +0000 Subject: [PATCH] Apply a patch by Micah Villmow to fix AsmParser to accept vector shift constant expressions, and add support for folding vector shift constant expressions. This fixes PR3802. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@67010 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/ConstantFold.cpp | 6 ++++++ lib/VMCore/Constants.cpp | 2 +- test/Assembler/vector-shift.ll | 17 ++++++++++++++--- 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/lib/VMCore/ConstantFold.cpp b/lib/VMCore/ConstantFold.cpp index f2847112afc..7e4902fd563 100644 --- a/lib/VMCore/ConstantFold.cpp +++ b/lib/VMCore/ConstantFold.cpp @@ -832,6 +832,12 @@ Constant *llvm::ConstantFoldBinaryInstruction(unsigned Opcode, return EvalVectorOp(CP1, CP2, VTy, ConstantExpr::getOr); case Instruction::Xor: return EvalVectorOp(CP1, CP2, VTy, ConstantExpr::getXor); + case Instruction::LShr: + return EvalVectorOp(CP1, CP2, VTy, ConstantExpr::getLShr); + case Instruction::AShr: + return EvalVectorOp(CP1, CP2, VTy, ConstantExpr::getAShr); + case Instruction::Shl: + return EvalVectorOp(CP1, CP2, VTy, ConstantExpr::getShl); } } } diff --git a/lib/VMCore/Constants.cpp b/lib/VMCore/Constants.cpp index 0be2811e354..ed1e04ad547 100644 --- a/lib/VMCore/Constants.cpp +++ b/lib/VMCore/Constants.cpp @@ -2095,7 +2095,7 @@ Constant *ConstantExpr::get(unsigned Opcode, Constant *C1, Constant *C2) { case Instruction::LShr: case Instruction::AShr: assert(C1->getType() == C2->getType() && "Op types should be identical!"); - assert(C1->getType()->isInteger() && + assert(C1->getType()->isIntOrIntVector() && "Tried to create a shift operation on a non-integer type!"); break; default: diff --git a/test/Assembler/vector-shift.ll b/test/Assembler/vector-shift.ll index 3b2c07c9035..1850e66e8ed 100644 --- a/test/Assembler/vector-shift.ll +++ b/test/Assembler/vector-shift.ll @@ -1,6 +1,6 @@ -; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep shl -; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep ashr -; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep lshr +; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep shl | count 1 +; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep ashr | count 1 +; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | grep lshr | count 1 define <4 x i32> @foo(<4 x i32> %a, <4 x i32> %b) nounwind { entry: @@ -19,3 +19,14 @@ entry: %cmp = ashr <4 x i32> %a, %b ; <4 x i32> [#uses=1] ret <4 x i32> %cmp } + +; Constant expressions: these should be folded. +define <2 x i64> @foo_ce() nounwind { + ret <2 x i64> shl (<2 x i64> , <2 x i64> ) +} +define <2 x i64> @bar_ce() nounwind { + ret <2 x i64> lshr (<2 x i64> , <2 x i64> ) +} +define <2 x i64> @baz_ce() nounwind { + ret <2 x i64> ashr (<2 x i64> , <2 x i64> ) +}