More sanity checks for function types.

Thanks goes to PyPy folks for generating broken stuff :)


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@44538 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Anton Korobeynikov 2007-12-03 19:16:54 +00:00
parent e268a40b1e
commit c1d848dd11
2 changed files with 26 additions and 2 deletions

View File

@ -1330,16 +1330,24 @@ Types
| Types '(' ArgTypeListI ')' OptFuncAttrs {
// Allow but ignore attributes on function types; this permits auto-upgrade.
// FIXME: remove in LLVM 3.0.
const Type* RetTy = *$1;
if (!(RetTy->isFirstClassType() || isa<OpaqueType>(RetTy)))
GEN_ERROR("LLVM Functions cannot return aggregates");
std::vector<const Type*> Params;
TypeWithAttrsList::iterator I = $3->begin(), E = $3->end();
for (; I != E; ++I ) {
const Type *Ty = I->Ty->get();
if (!(Ty->isFirstClassType() || isa<OpaqueType>(Ty)))
GEN_ERROR("Function arguments must be value types!");
Params.push_back(Ty);
}
CHECK_FOR_ERROR
bool isVarArg = Params.size() && Params.back() == Type::VoidTy;
if (isVarArg) Params.pop_back();
FunctionType *FT = FunctionType::get(*$1, Params, isVarArg);
FunctionType *FT = FunctionType::get(RetTy, Params, isVarArg);
delete $3; // Delete the argument list
delete $1; // Delete the return type handle
$$ = new PATypeHolder(HandleUpRefs(FT));
@ -1352,8 +1360,12 @@ Types
TypeWithAttrsList::iterator I = $3->begin(), E = $3->end();
for ( ; I != E; ++I ) {
const Type* Ty = I->Ty->get();
if (!(Ty->isFirstClassType() || isa<OpaqueType>(Ty)))
GEN_ERROR("Function arguments must be value types!");
Params.push_back(Ty);
}
CHECK_FOR_ERROR
bool isVarArg = Params.size() && Params.back() == Type::VoidTy;
if (isVarArg) Params.pop_back();

View File

@ -1330,16 +1330,24 @@ Types
| Types '(' ArgTypeListI ')' OptFuncAttrs {
// Allow but ignore attributes on function types; this permits auto-upgrade.
// FIXME: remove in LLVM 3.0.
const Type* RetTy = *$1;
if (!(RetTy->isFirstClassType() || isa<OpaqueType>(RetTy)))
GEN_ERROR("LLVM Functions cannot return aggregates");
std::vector<const Type*> Params;
TypeWithAttrsList::iterator I = $3->begin(), E = $3->end();
for (; I != E; ++I ) {
const Type *Ty = I->Ty->get();
if (!(Ty->isFirstClassType() || isa<OpaqueType>(Ty)))
GEN_ERROR("Function arguments must be value types!");
Params.push_back(Ty);
}
CHECK_FOR_ERROR
bool isVarArg = Params.size() && Params.back() == Type::VoidTy;
if (isVarArg) Params.pop_back();
FunctionType *FT = FunctionType::get(*$1, Params, isVarArg);
FunctionType *FT = FunctionType::get(RetTy, Params, isVarArg);
delete $3; // Delete the argument list
delete $1; // Delete the return type handle
$$ = new PATypeHolder(HandleUpRefs(FT));
@ -1352,8 +1360,12 @@ Types
TypeWithAttrsList::iterator I = $3->begin(), E = $3->end();
for ( ; I != E; ++I ) {
const Type* Ty = I->Ty->get();
if (!(Ty->isFirstClassType() || isa<OpaqueType>(Ty)))
GEN_ERROR("Function arguments must be value types!");
Params.push_back(Ty);
}
CHECK_FOR_ERROR
bool isVarArg = Params.size() && Params.back() == Type::VoidTy;
if (isVarArg) Params.pop_back();