6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-26 07:24:25 +00:00
Code Issues Projects Releases Wiki Activity

Teach TBAA analysis to report errors on cyclic TBAA metadata rather than hanging.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@232144 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Owen Anderson
2015-03-13 07:09:33 +00:00
parent 39fcd2305a
commit c20535dff6
2 changed files with 35 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/Analysis/TypeBasedAliasAnalysis.cpp
View File

@ -129,6 +129,7 @@
#include "llvm/IR/Module.h" #include "llvm/IR/Module.h"
#include "llvm/Pass.h" #include "llvm/Pass.h"
#include "llvm/Support/CommandLine.h" #include "llvm/Support/CommandLine.h"
#include "llvm/ADT/SetVector.h"
using namespace llvm; using namespace llvm;
// A handy option for disabling TBAA functionality. The same effect can also be // A handy option for disabling TBAA functionality. The same effect can also be
@ -578,18 +579,22 @@ MDNode *MDNode::getMostGenericTBAA(MDNode *A, MDNode *B) {
if (!B) return nullptr; if (!B) return nullptr;
} }
SmallVector<MDNode *, 4> PathA; SmallSetVector<MDNode *, 4> PathA;
MDNode *T = A; MDNode *T = A;
while (T) { while (T) {
PathA.push_back(T); if (PathA.count(T))
report_fatal_error("Cycle found in TBAA metadata.");
PathA.insert(T);
T = T->getNumOperands() >= 2 ? cast_or_null<MDNode>(T->getOperand(1)) T = T->getNumOperands() >= 2 ? cast_or_null<MDNode>(T->getOperand(1))
: nullptr; : nullptr;
} }
SmallVector<MDNode *, 4> PathB; SmallSetVector<MDNode *, 4> PathB;
T = B; T = B;
while (T) { while (T) {
PathB.push_back(T); if (PathB.count(T))
report_fatal_error("Cycle found in TBAA metadata.");
PathB.insert(T);
T = T->getNumOperands() >= 2 ? cast_or_null<MDNode>(T->getOperand(1)) T = T->getNumOperands() >= 2 ? cast_or_null<MDNode>(T->getOperand(1))
: nullptr; : nullptr;
} }

26
test/Analysis/TypeBasedAliasAnalysis/cyclic.ll Normal file
View File

@ -0,0 +1,26 @@
; RUN: not opt -instcombine < %s 2>&1 | FileCheck %s
; CHECK: Cycle found in TBAA metadata.
define void @test6(i32* %gi) #0 {
entry:
store i32 42, i32* %gi, align 4, !tbaa !0
br label %for.cond
for.cond: ; preds = %for.body, %entry
br i1 undef, label %for.body, label %for.end
for.body: ; preds = %for.cond
store i32 undef, i32* %gi, align 4, !tbaa !2
br label %for.cond
for.end: ; preds = %for.cond
ret void
}
attributes #0 = { nounwind ssp uwtable }
!0 = !{!1, !1, i64 0}
!1 = !{!"Simple C/C++ TBAA"}
!2 = distinct !{!3, !2, i64 0}
!3 = !{!"int", !4}
!4 = !{!"omnipotent ", !1}