6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-06-21 02:24:22 +00:00
Code Issues Projects Releases Wiki Activity

In guaranteed tailcall mode, don't decline the tailcall optimization

Browse Source 
for blocks ending in "unreachable".


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@95565 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dan Gohman
2010-02-08 20:34:14 +00:00
parent 1797ed50f4
commit c2e93b255e
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
View File

@ -4205,13 +4205,16 @@ isInTailCallPosition(CallSite CS, Attributes CalleeRetAttr,
const ReturnInst *Ret = dyn_cast<ReturnInst>(Term); const ReturnInst *Ret = dyn_cast<ReturnInst>(Term);
const Function *F = ExitBB->getParent(); const Function *F = ExitBB->getParent();
// The block must end in a return statement. // The block must end in a return statement or unreachable.
// FIXME: Disallow tailcall if the block ends in an unreachable for now. //
// The way tailcall optimization is currently implemented means it will // FIXME: Decline tailcall if it's not guaranteed and if the block ends in
// add an epilogue followed by a jump. That is not profitable. Also, if // an unreachable, for now. The way tailcall optimization is currently
// the callee is a special function (e.g. longjmp on x86), it can end up // implemented means it will add an epilogue followed by a jump. That is
// causing miscompilation that has not been fully understood. // not profitable. Also, if the callee is a special function (e.g.
if (!Ret) return false; // longjmp on x86), it can end up causing miscompilation that has not
// been fully understood.
if (!Ret &&
(!GuaranteedTailCallOpt || !isa<UnreachableInst>(Term))) return false;
// If I will have a chain, make sure no other instruction that will have a // If I will have a chain, make sure no other instruction that will have a
// chain interposes between I and the return. // chain interposes between I and the return.

5
test/CodeGen/X86/tailcall1.ll
View File

@ -1,4 +1,7 @@
; RUN: llc < %s -march=x86 -tailcallopt | grep TAILCALL | count 4 ; RUN: llc < %s -march=x86 -tailcallopt | grep TAILCALL | count 5
; With -tailcallopt, CodeGen guarantees a tail call optimization
; for all of these.
declare fastcc i32 @tailcallee(i32 %a1, i32 %a2, i32 %a3, i32 %a4) declare fastcc i32 @tailcallee(i32 %a1, i32 %a2, i32 %a3, i32 %a4)