diff --git a/test/tools/gold/remarks.ll b/test/tools/gold/remarks.ll new file mode 100644 index 00000000000..f84016e9047 --- /dev/null +++ b/test/tools/gold/remarks.ll @@ -0,0 +1,22 @@ +; RUN: llvm-as %s -o %t.o + +; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ +; RUN: -plugin-opt=-pass-remarks=inline %t.o -o %t2.o 2>&1 | FileCheck %s + +; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \ +; RUN: %t.o -o %t2.o 2>&1 | FileCheck -allow-empty --check-prefix=NO-REMARK %s + + +; CHECK: f inlined into _start +; NO-REMARK-NOT: inlined +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +define i32 @f() { + ret i32 0 +} + +define i32 @_start() { + %call = call i32 @f() + ret i32 %call +} diff --git a/tools/gold/gold-plugin.cpp b/tools/gold/gold-plugin.cpp index 2aec4e21bc4..faf2a6b9565 100644 --- a/tools/gold/gold-plugin.cpp +++ b/tools/gold/gold-plugin.cpp @@ -296,12 +296,9 @@ static void diagnosticHandler(const DiagnosticInfo &DI, void *Context) { Level = LDPL_WARNING; break; case DS_Note: + case DS_Remark: Level = LDPL_INFO; break; - // FIXME: Just ignore remarks for now. They are always passed by - // if there is a custom diagnostic handler, so we get flooded. - case DS_Remark: - return; } message(Level, "LLVM gold plugin: %s", ErrStorage.c_str()); } @@ -812,7 +809,7 @@ static ld_plugin_status allSymbolsReadHook(raw_fd_ostream *ApiFile) { return LDPS_OK; LLVMContext Context; - Context.setDiagnosticHandler(diagnosticHandler); + Context.setDiagnosticHandler(diagnosticHandler, nullptr, true); std::unique_ptr Combined(new Module("ld-temp.o", Context)); Linker L(Combined.get());