6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-02-24 12:29:33 +00:00
Code Issues Projects Releases Wiki Activity

[mips] Emit the .insn directive for empty basic blocks.

Browse Source 
Summary:
In microMIPS, labels need to know whether they are on code or data. This is
indicated with STO_MIPS_MICROMIPS and can be inferred by being followed
by instructions. For empty basic blocks, we can ensure this by emitting the
.insn directive after the label.

Also, this fixes some failures in our out-of-tree microMIPS buildbots, for the
exception handling regression tests under: SingleSource/Regression/C++/EH

Reviewers: dsanders

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D9530

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@236815 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Vasileios Kalintiris 2015-05-08 09:10:15 +00:00
parent b1e759524d
commit ca33d72658
3 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Target/Mips/MipsAsmPrinter.cpp
View File

@ -384,6 +384,12 @@ void MipsAsmPrinter::EmitFunctionBodyEnd() {
OutStreamer->EmitDataRegion(MCDR_DataRegionEnd);
}
void MipsAsmPrinter::EmitBasicBlockEnd(const MachineBasicBlock &MBB) {
MipsTargetStreamer &TS = getTargetStreamer();
if (MBB.size() == 0)
TS.emitDirectiveInsn();
}
/// isBlockOnlyReachableByFallthough - Return true if the basic block has
/// exactly one predecessor and the control transfer mechanism between
/// the predecessor and this block is a fall-through.

1
lib/Target/Mips/MipsAsmPrinter.h
View File

@ -124,6 +124,7 @@ public:
void EmitFunctionEntryLabel() override;
void EmitFunctionBodyStart() override;
void EmitFunctionBodyEnd() override;
void EmitBasicBlockEnd(const MachineBasicBlock &MBB) override;
bool isBlockOnlyReachableByFallthrough(
const MachineBasicBlock* MBB) const override;
bool PrintAsmOperand(const MachineInstr *MI, unsigned OpNo,

27
test/CodeGen/Mips/insn-zero-size-bb.ll Normal file
View File

@ -0,0 +1,27 @@
; RUN: llc < %s -march=mips -mcpu=mips32 | FileCheck %s
; RUN: llc < %s -march=mips -mcpu=mips32r3 -mattr=+micromips | FileCheck %s
; RUN: llc < %s -march=mips -mcpu=mips16 | FileCheck %s
; Verify that we emit the .insn directive for zero-sized (empty) basic blocks.
; This only really matters for microMIPS and MIPS16.
declare i32 @foo(...)
declare void @bar()
define void @main() {
entry:
invoke void @bar() #0
to label %unreachable unwind label %return
unreachable:
; CHECK: ${{.*}}: # %unreachable
; CHECK-NEXT: .insn
unreachable
return:
%0 = landingpad { i8*, i32 } personality i8* bitcast (i32 (...)* @foo to i8*)
catch i8* null
ret void
}
attributes #0 = { noreturn }