6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-10-01 13:17:01 +00:00
Code Issues Projects Releases Wiki Activity

[InlineFunction] Don't add lifetime markers for zero-sized allocas.

Browse Source 
This commit fixes the code which adds lifetime markers in InlineFunction to skip
zero-sized allocas instead of asserting on them.

rdar://problem/20531155


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235312 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Akira Hatanaka
2015-04-20 16:11:05 +00:00
parent d9b36e1007
commit ca9313e65e
2 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Transforms/Utils/InlineFunction.cpp
View File

@@ -1167,7 +1167,11 @@ bool llvm::InlineFunction(CallSite CS, InlineFunctionInfo &IFI,
Type *AllocaType = AI->getAllocatedType(); Type *AllocaType = AI->getAllocatedType();
uint64_t AllocaTypeSize = DL.getTypeAllocSize(AllocaType); uint64_t AllocaTypeSize = DL.getTypeAllocSize(AllocaType);
uint64_t AllocaArraySize = AIArraySize->getLimitedValue(); uint64_t AllocaArraySize = AIArraySize->getLimitedValue();
assert(AllocaArraySize > 0 && "array size of AllocaInst is zero");
// Don't add markers for zero-sized allocas.
if (AllocaArraySize == 0)
continue;
// Check that array size doesn't saturate uint64_t and doesn't // Check that array size doesn't saturate uint64_t and doesn't
// overflow when it's multiplied by type size. // overflow when it's multiplied by type size.
if (AllocaArraySize != ~0ULL && if (AllocaArraySize != ~0ULL &&

24
test/Transforms/Inline/crash-lifetime-marker.ll Normal file
View File

@@ -0,0 +1,24 @@
; RUN: opt < %s -inline -S | FileCheck %s
; InlineFunction would assert inside the loop that leaves lifetime markers if
; there was an zero-sized AllocaInst. Check that it doesn't assert and doesn't
; leave lifetime markers in that case.
declare i32 @callee2(i8*)
define i32 @callee1(i32 %count) {
%a0 = alloca i8, i32 %count, align 4
%call0 = call i32 @callee2(i8* %a0)
ret i32 %call0
}
; CHECK-LABEL: define i32 @caller1(
; CHECK: [[ALLOCA:%[a-z0-9\.]+]] = alloca i8
; CHECK-NOT: call void @llvm.lifetime.start(
; CHECK: call i32 @callee2(i8* [[ALLOCA]])
; CHECK-NOT: call void @llvm.lifetime.end(
define i32 @caller1(i32 %count) {
%call0 = call i32 @callee1(i32 0)
ret i32 %call0
}