6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-11-02 07:11:49 +00:00
Code Issues Projects Releases Wiki Activity

mention possibility of using a visitor

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@43726 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner 2007-11-05 19:25:14 +00:00
parent cf9893d28c
commit cac2135bc8
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
docs/tutorial/LangImpl3.html
View File

@ -62,7 +62,7 @@ we define virtual codegen methods in each AST class:</p>
class ExprAST {
public:
virtual ~ExprAST() {}
virtual Value *Codegen() = 0;
<b>virtual Value *Codegen() = 0;</b>
};
/// NumberExprAST - Expression class for numeric literals like "1.0".
@ -70,7 +70,7 @@ class NumberExprAST : public ExprAST {
double Val;
public:
explicit NumberExprAST(double val) : Val(val) {}
virtual Value *Codegen();
<b>virtual Value *Codegen();</b>
};
...
</pre>
@ -88,6 +88,11 @@ more information, please read up on <a
href="http://en.wikipedia.org/wiki/Static_single_assignment_form">Static Single
Assignment</a> - the concepts are really quite natural once you grok them.</p>
<p>Note that instead of adding virtual methods to the ExprAST class hierarchy,
it could also make sense to use a visitor pattern or some other way to model
this. Again, this tutorial won't dwell on good software engineering practices:
for our purposes, adding virtual methods is simplest.</p>
<p>The
second thing we want is an "Error" method like we used for parser, which will
be used to report errors found during code generation (for example, use of an