Revert the part of 45848 that treated weak globals

as weak globals rather than commons.  While not wrong,
this change tickled a latent bug in Darwin's strip,
so revert it for now as a workaround.



git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@46144 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Dale Johannesen 2008-01-17 23:04:07 +00:00
parent 58c5818c01
commit d15d086956
2 changed files with 4 additions and 4 deletions

View File

@ -917,7 +917,8 @@ bool DarwinAsmPrinter::doFinalization(Module &M) {
if (C->isNullValue() && /* FIXME: Verify correct */
!I->hasSection() &&
(I->hasInternalLinkage() || I->hasExternalLinkage())) {
(I->hasInternalLinkage() || I->hasWeakLinkage() ||
I->hasLinkOnceLinkage() || I->hasExternalLinkage())) {
if (Size == 0) Size = 1; // .comm Foo, 0 is undefined, avoid it.
if (I->hasExternalLinkage()) {
O << "\t.globl " << name << '\n';

View File

@ -181,9 +181,8 @@ bool X86SharedAsmPrinter::doFinalization(Module &M) {
}
if (!I->isThreadLocal() &&
(I->hasInternalLinkage() ||
(!Subtarget->isTargetDarwin() &&
(I->hasWeakLinkage() || I->hasLinkOnceLinkage())))) {
(I->hasInternalLinkage() || I->hasWeakLinkage() ||
I->hasLinkOnceLinkage())) {
if (Size == 0) Size = 1; // .comm Foo, 0 is undefined, avoid it.
if (!NoZerosInBSS && TAI->getBSSSection())
SwitchToDataSection(TAI->getBSSSection(), I);