From d72d67da07299d7773bfd97f75a469accfdc58de Mon Sep 17 00:00:00 2001 From: Nuno Lopes Date: Fri, 25 May 2012 21:15:17 +0000 Subject: [PATCH] bounds checking: add support for byval arguments git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@157498 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/BoundsChecking.cpp | 10 +++++++++- test/Transforms/BoundsChecking/simple.ll | 9 +++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/lib/Transforms/Scalar/BoundsChecking.cpp b/lib/Transforms/Scalar/BoundsChecking.cpp index 4c3dea2317a..7b1a4170408 100644 --- a/lib/Transforms/Scalar/BoundsChecking.cpp +++ b/lib/Transforms/Scalar/BoundsChecking.cpp @@ -104,7 +104,6 @@ void BoundsChecking::emitBranchToTrap(Value *Cmp) { BasicBlock *Cont = OldBB->splitBasicBlock(Inst); OldBB->getTerminator()->eraseFromParent(); - // FIXME: add unlikely branch taken metadata? if (Cmp) BranchInst::Create(getTrapBB(), Cont, Cmp, OldBB); else @@ -152,6 +151,15 @@ ConstTriState BoundsChecking::computeAllocSize(Value *Alloc, uint64_t &Size, SizeValue = Builder->CreateMul(SizeValue, ArraySize); return NotConst; + // function arguments + } else if (Argument *A = dyn_cast(Alloc)) { + if (!A->hasByValAttr()) + return Dunno; + + PointerType *PT = cast(A->getType()); + Size = TD->getTypeAllocSize(PT->getElementType()); + return Const; + // ptr = select(ptr1, ptr2) } else if (SelectInst *SI = dyn_cast(Alloc)) { uint64_t SizeFalse; diff --git a/test/Transforms/BoundsChecking/simple.ll b/test/Transforms/BoundsChecking/simple.ll index f24d9e1f8df..62c2e9026bc 100644 --- a/test/Transforms/BoundsChecking/simple.ll +++ b/test/Transforms/BoundsChecking/simple.ll @@ -107,3 +107,12 @@ define void @f10(i64 %x, i64 %y) nounwind { %4 = load i128* %3, align 4 ret void } + +; CHECK: @f11 +define void @f11(i128* byval %x) nounwind { + %1 = bitcast i128* %x to i8* + %2 = getelementptr inbounds i8* %1, i64 16 +; CHECK: br label + %3 = load i8* %2, align 4 + ret void +}