6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-05-21 12:38:45 +00:00
Code Issues Projects Releases Wiki Activity

Fix PR2289: vr defined by multiple implicit_def as result of coalescing.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51648 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Evan Cheng 2008-05-28 17:40:10 +00:00
parent 33d3d4ad40
commit d77d4f98fb
2 changed files with 19 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/CodeGen/SimpleRegisterCoalescing.cpp
View File

@ -751,7 +751,7 @@ bool SimpleRegisterCoalescing::CanCoalesceWithImpDef(MachineInstr *CopyMI,
/// identity copies so they will be removed. /// identity copies so they will be removed.
void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li, void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li,
VNInfo *VNI) { VNInfo *VNI) {
MachineInstr *ImpDef = NULL; SmallVector<MachineInstr*, 4> ImpDefs;
MachineOperand *LastUse = NULL; MachineOperand *LastUse = NULL;
unsigned LastUseIdx = li_->getUseIndex(VNI->def); unsigned LastUseIdx = li_->getUseIndex(VNI->def);
for (MachineRegisterInfo::reg_iterator RI = mri_->reg_begin(li.reg), for (MachineRegisterInfo::reg_iterator RI = mri_->reg_begin(li.reg),
@ -761,8 +761,7 @@ void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li,
++RI; ++RI;
if (MO->isDef()) { if (MO->isDef()) {
if (MI->getOpcode() == TargetInstrInfo::IMPLICIT_DEF) { if (MI->getOpcode() == TargetInstrInfo::IMPLICIT_DEF) {
assert(!ImpDef && "Multiple implicit_def defining same register?"); ImpDefs.push_back(MI);
ImpDef = MI;
} }
continue; continue;
} }
@ -790,9 +789,13 @@ void SimpleRegisterCoalescing::RemoveCopiesFromValNo(LiveInterval &li,
if (LastUse) if (LastUse)
LastUse->setIsKill(); LastUse->setIsKill();
else { else {
// Remove dead implicit_def. // Remove dead implicit_def's.
li_->RemoveMachineInstrFromMaps(ImpDef); while (!ImpDefs.empty()) {
ImpDef->eraseFromParent(); MachineInstr *ImpDef = ImpDefs.back();
ImpDefs.pop_back();
li_->RemoveMachineInstrFromMaps(ImpDef);
ImpDef->eraseFromParent();
}
} }
} }

10
test/CodeGen/X86/2008-05-28-CoalescerBug.ll Normal file
View File

@ -0,0 +1,10 @@
; RUN: llvm-as < %s | llc -mtriple=x86_64-unknown-linux-gnu
; PR2289
define void @_ada_ca11001() {
entry:
%tmp59 = call i16 @ca11001_0__cartesian_assign( i8 zeroext 0, i8 zeroext 0, i16 undef ) ; <i16> [#uses=0]
unreachable
}
declare i16 @ca11001_0__cartesian_assign(i8 zeroext , i8 zeroext , i16)