6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-11-01 15:17:25 +00:00
Code Issues Projects Releases Wiki Activity

IR: Store MDNodes in a separate LeakDetector container

Browse Source 
This gives us better leak detection messages, like `Value` has.

This also has the side effect of papering over a problem where
`MachineInstr`s are added as garbage to the leak detector and then
deleted without being removed.  If `MDNode::getTemporary()` allocates an
`MDNodeFwdDecl` in the same spot, the leak detector asserts.  By
separating `MDNode`s into their own container we lose that assertion.

Since `MachineInstr` is required to have a trivial destructor, its usage
of `LeakDetector` at all is pretty suspect.  I'll be sending a patch
soon to strip that out.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@224060 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Duncan P. N. Exon Smith
2014-12-11 21:39:39 +00:00
parent 5b17297b3d
commit da75f7277e
3 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/IR/LeakDetector.cpp
View File

@@ -14,6 +14,7 @@
#include "llvm/IR/LeakDetector.h"
#include "LLVMContextImpl.h"
#include "llvm/ADT/SmallPtrSet.h"
#include "llvm/IR/Metadata.h"
#include "llvm/IR/Value.h"
#include "llvm/Support/Compiler.h"
#include "llvm/Support/ManagedStatic.h"
@@ -39,6 +40,11 @@ void LeakDetector::addGarbageObjectImpl(const Value *Object) {
pImpl->LLVMObjects.addGarbage(Object);
}
void LeakDetector::addGarbageObjectImpl(const MDNode *Object) {
LLVMContextImpl *pImpl = Object->getContext().pImpl;
pImpl->LLVMMDObjects.addGarbage(Object);
}
void LeakDetector::removeGarbageObjectImpl(void *Object) {
sys::SmartScopedLock<true> Lock(*ObjectsLock);
Objects->removeGarbage(Object);
@@ -49,6 +55,11 @@ void LeakDetector::removeGarbageObjectImpl(const Value *Object) {
pImpl->LLVMObjects.removeGarbage(Object);
}
void LeakDetector::removeGarbageObjectImpl(const MDNode *Object) {
LLVMContextImpl *pImpl = Object->getContext().pImpl;
pImpl->LLVMMDObjects.removeGarbage(Object);
}
void LeakDetector::checkForGarbageImpl(LLVMContext &Context,
const std::string &Message) {
LLVMContextImpl *pImpl = Context.pImpl;
@@ -56,10 +67,12 @@ void LeakDetector::checkForGarbageImpl(LLVMContext &Context,
Objects->setName("GENERIC");
pImpl->LLVMObjects.setName("LLVM");
pImpl->LLVMMDObjects.setName("LLVM-MD");
// use non-short-circuit version so that both checks are performed
if (Objects->hasGarbage(Message) |
pImpl->LLVMObjects.hasGarbage(Message))
pImpl->LLVMObjects.hasGarbage(Message) |
pImpl->LLVMMDObjects.hasGarbage(Message))
errs() << "\nThis is probably because you removed an object, but didn't "
<< "delete it. Please check your code for memory leaks.\n";