6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-08-08 19:25:47 +00:00
Code Issues Projects Releases Wiki Activity

Abstract out the predicate which decides whether a function gets complete

Browse Source 
arguments or not...


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@6987 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Chris Lattner
2003-06-29 22:37:07 +00:00
parent 06e24c8447
commit dea8146787
1 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
lib/Analysis/DataStructure/TopDownClosure.cpp
View File

@@ -94,6 +94,18 @@ DSGraph &TDDataStructures::getOrCreateDSGraph(Function &F) {
return *G; return *G;
} }
/// FunctionHasCompleteArguments - This function returns true if it is safe not
/// to mark arguments to the function complete.
///
/// FIXME: Need to check if all callers have been found, or rather if a
/// funcpointer escapes!
///
static bool FunctionHasCompleteArguments(Function &F) {
return F.hasInternalLinkage();
}
void TDDataStructures::calculateGraph(Function &F) { void TDDataStructures::calculateGraph(Function &F) {
// Make sure this graph has not already been calculated, and that we don't get // Make sure this graph has not already been calculated, and that we don't get
// into an infinite loop with mutually recursive functions. // into an infinite loop with mutually recursive functions.
@@ -106,10 +118,8 @@ void TDDataStructures::calculateGraph(Function &F) {
// Recompute the Incomplete markers and eliminate unreachable nodes. // Recompute the Incomplete markers and eliminate unreachable nodes.
Graph.maskIncompleteMarkers(); Graph.maskIncompleteMarkers();
// FIXME: Need to check if all callers have been found, or rather if a unsigned Flags = FunctionHasCompleteArguments(F) ?
// funcpointer escapes! DSGraph::IgnoreFormalArgs : DSGraph::MarkFormalArgs;
unsigned Flags = F.hasInternalLinkage() ?
DSGraph::IgnoreFormalArgs : DSGraph::MarkFormalArgs;
Graph.markIncompleteNodes(Flags | DSGraph::IgnoreGlobals); Graph.markIncompleteNodes(Flags | DSGraph::IgnoreGlobals);
Graph.removeDeadNodes(DSGraph::RemoveUnreachableGlobals); Graph.removeDeadNodes(DSGraph::RemoveUnreachableGlobals);
@@ -152,11 +162,11 @@ void TDDataStructures::calculateGraph(Function &F) {
++I; ++I;
} else { } else {
// For each callee... // For each callee...
Function *Callee = I->first; Function &Callee = *I->first;
DSGraph &CG = getOrCreateDSGraph(*Callee); // Get the callee's graph... DSGraph &CG = getOrCreateDSGraph(Callee); // Get the callee's graph...
DEBUG(std::cerr << "\t [TD] Inlining into callee '" << Callee->getName() DEBUG(std::cerr << "\t [TD] Inlining into callee '" << Callee.getName()
<< "'\n"); << "'\n");
// Clone our current graph into the callee... // Clone our current graph into the callee...
hash_map<Value*, DSNodeHandle> OldValMap; hash_map<Value*, DSNodeHandle> OldValMap;
@@ -172,7 +182,7 @@ void TDDataStructures::calculateGraph(Function &F) {
// current function calls this callee multiple times with different // current function calls this callee multiple times with different
// signatures. // signatures.
// //
for (; I != E && I->first == Callee; ++I) { for (; I != E && I->first == &Callee; ++I) {
// Map call site into callee graph // Map call site into callee graph
DSCallSite NewCS(*I->second, OldNodeMap); DSCallSite NewCS(*I->second, OldNodeMap);
@@ -180,13 +190,13 @@ void TDDataStructures::calculateGraph(Function &F) {
NewCS.getRetVal().mergeWith(CG.getRetNode()); NewCS.getRetVal().mergeWith(CG.getRetNode());
// Resolve all of the arguments... // Resolve all of the arguments...
Function::aiterator AI = Callee->abegin(); Function::aiterator AI = Callee.abegin();
for (unsigned i = 0, e = NewCS.getNumPtrArgs(); for (unsigned i = 0, e = NewCS.getNumPtrArgs();
i != e && AI != Callee->aend(); ++i, ++AI) { i != e && AI != Callee.aend(); ++i, ++AI) {
// Advance the argument iterator to the first pointer argument... // Advance the argument iterator to the first pointer argument...
while (AI != Callee->aend() && !DS::isPointerType(AI->getType())) while (AI != Callee.aend() && !DS::isPointerType(AI->getType()))
++AI; ++AI;
if (AI == Callee->aend()) break; if (AI == Callee.aend()) break;
// Add the link from the argument scalar to the provided value // Add the link from the argument scalar to the provided value
DSNodeHandle &NH = CG.getNodeForValue(AI); DSNodeHandle &NH = CG.getNodeForValue(AI);