diff --git a/include/llvm/ADT/StringMap.h b/include/llvm/ADT/StringMap.h index 1fa128a5fc5..745428880be 100644 --- a/include/llvm/ADT/StringMap.h +++ b/include/llvm/ADT/StringMap.h @@ -389,8 +389,8 @@ private: template class StringMapIterator : public StringMapConstIterator { public: - StringMapIterator(StringMapImpl::ItemBucket *Bucket, - bool NoAdvance = false) + explicit StringMapIterator(StringMapImpl::ItemBucket *Bucket, + bool NoAdvance = false) : StringMapConstIterator(Bucket, NoAdvance) { } StringMapEntry &operator*() const { diff --git a/include/llvm/ExecutionEngine/ExecutionEngine.h b/include/llvm/ExecutionEngine/ExecutionEngine.h index 5b33e15d906..cc0ab0bcd9f 100644 --- a/include/llvm/ExecutionEngine/ExecutionEngine.h +++ b/include/llvm/ExecutionEngine/ExecutionEngine.h @@ -248,7 +248,7 @@ public: } protected: - ExecutionEngine(ModuleProvider *P); + explicit ExecutionEngine(ModuleProvider *P); void emitGlobals(); diff --git a/include/llvm/ExecutionEngine/GenericValue.h b/include/llvm/ExecutionEngine/GenericValue.h index fab82af405e..0371009bdd4 100644 --- a/include/llvm/ExecutionEngine/GenericValue.h +++ b/include/llvm/ExecutionEngine/GenericValue.h @@ -34,7 +34,7 @@ struct GenericValue { APInt IntVal; // also used for long doubles GenericValue() : DoubleVal(0.0), IntVal(1,0) {} - GenericValue(void *V) : PointerVal(V), IntVal(1,0) { } + explicit GenericValue(void *V) : PointerVal(V), IntVal(1,0) { } }; inline GenericValue PTOGV(void *P) { return GenericValue(P); } diff --git a/lib/Analysis/IPA/Andersens.cpp b/lib/Analysis/IPA/Andersens.cpp index cc7ad7e7a77..474781f6df3 100644 --- a/lib/Analysis/IPA/Andersens.cpp +++ b/lib/Analysis/IPA/Andersens.cpp @@ -246,7 +246,7 @@ namespace { // Used for work list prioritization. unsigned Timestamp; - Node(bool direct = true) : + explicit Node(bool direct = true) : Val(0), Edges(0), PointsTo(0), OldPointsTo(0), PointerEquivLabel(0), LocationEquivLabel(0), PredEdges(0), ImplicitPredEdges(0), PointedToBy(0), NumInEdges(0), diff --git a/lib/CodeGen/CollectorMetadata.cpp b/lib/CodeGen/CollectorMetadata.cpp index 57349390b01..43f3d431e97 100644 --- a/lib/CodeGen/CollectorMetadata.cpp +++ b/lib/CodeGen/CollectorMetadata.cpp @@ -30,7 +30,7 @@ namespace { std::ostream &OS; public: - Printer(std::ostream &OS = *cerr); + explicit Printer(std::ostream &OS = *cerr); const char *getPassName() const; void getAnalysisUsage(AnalysisUsage &AU) const; diff --git a/lib/CodeGen/ELFWriter.cpp b/lib/CodeGen/ELFWriter.cpp index efdf029c4a3..d054adb9de6 100644 --- a/lib/CodeGen/ELFWriter.cpp +++ b/lib/CodeGen/ELFWriter.cpp @@ -72,7 +72,7 @@ namespace llvm { std::vector *OutBuffer; size_t FnStart; public: - ELFCodeEmitter(ELFWriter &ew) : EW(ew), TM(EW.TM), OutBuffer(0) {} + explicit ELFCodeEmitter(ELFWriter &ew) : EW(ew), TM(EW.TM), OutBuffer(0) {} void startFunction(MachineFunction &F); bool finishFunction(MachineFunction &F); diff --git a/lib/CodeGen/SimpleRegisterCoalescing.h b/lib/CodeGen/SimpleRegisterCoalescing.h index c3b28956635..fcdab4a5182 100644 --- a/lib/CodeGen/SimpleRegisterCoalescing.h +++ b/lib/CodeGen/SimpleRegisterCoalescing.h @@ -48,7 +48,7 @@ namespace llvm { /// struct CopyRecSort : public std::binary_function { JoinPriorityQueue *JPQ; - CopyRecSort(JoinPriorityQueue *jpq) : JPQ(jpq) {} + explicit CopyRecSort(JoinPriorityQueue *jpq) : JPQ(jpq) {} CopyRecSort(const CopyRecSort &RHS) : JPQ(RHS.JPQ) {} bool operator()(CopyRec left, CopyRec right) const; }; @@ -61,7 +61,8 @@ namespace llvm { std::priority_queue, SF> Queue; public: - JoinPriorityQueue(SimpleRegisterCoalescing *rc) : Rc(rc), Queue(SF(this)) {} + explicit JoinPriorityQueue(SimpleRegisterCoalescing *rc) + : Rc(rc), Queue(SF(this)) {} bool empty() const { return Queue.empty(); } void push(CopyRec R) { Queue.push(R); } diff --git a/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp b/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp index f45875faa38..4e9b77be84f 100644 --- a/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp +++ b/lib/ExecutionEngine/Interpreter/ExternalFunctions.cpp @@ -653,7 +653,7 @@ GenericValue lle_X_fwrite(FunctionType *FT, const vector &Args) { // char *fgets(char *s, int n, FILE *stream); GenericValue lle_X_fgets(FunctionType *FT, const vector &Args) { assert(Args.size() == 3); - return GVTOP(fgets((char*)GVTOP(Args[0]), Args[1].IntVal.getZExtValue(), + return PTOGV(fgets((char*)GVTOP(Args[0]), Args[1].IntVal.getZExtValue(), getFILE(GVTOP(Args[2])))); }