6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2024-12-29 10:32:47 +00:00
Code Issues Projects Releases Wiki Activity

Reenable use of TBAA during CodeGen

Browse Source 
We had disabled use of TBAA during CodeGen (even when otherwise using AA)
because the ptrtoint/inttoptr used by CGP for address sinking caused BasicAA to
miss basic type punning that it should catch (and, thus, we'd fail to override
TBAA when we should).

However, when AA is in use during CodeGen, CGP now uses normal GEPs and
bitcasts, instead of ptrtoint/inttoptr, when doing address sinking. As a
result, BasicAA should be able to make us do the right thing in the face of
type-punning, and it seems safe to enable use of TBAA again. self-hosting seems
fine on PPC64/Linux on the P7, with TBAA enabled and -misched=shuffle.

Note: We still don't update TBAA when merging stack slots, although because
BasicAA should now catch all such cases, this is no longer a blocking issue.
Nevertheless, I plan to commit code to deal with this properly in the near
future.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@206093 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Hal Finkel 2014-04-12 01:26:00 +00:00
parent 24517d023f
commit e13b87c08d
4 changed files with 3 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/CodeGen/ScheduleDAGInstrs.cpp
View File

@ -45,14 +45,8 @@ static cl::opt<bool> EnableAASchedMI("enable-aa-sched-mi", cl::Hidden,
cl::ZeroOrMore, cl::init(false),
cl::desc("Enable use of AA during MI GAD construction"));
// FIXME: Enable the use of TBAA. There are two known issues preventing this:
// 1. Stack coloring does not update TBAA when merging allocas
// 2. CGP inserts ptrtoint/inttoptr pairs when sinking address computations.
// Because BasicAA does not handle inttoptr, we'll often miss basic type
// punning idioms that we need to catch so we don't miscompile real-world
// code.
static cl::opt<bool> UseTBAA("use-tbaa-in-sched-mi", cl::Hidden,
cl::init(false), cl::desc("Enable use of TBAA during MI GAD construction"));
cl::init(true), cl::desc("Enable use of TBAA during MI GAD construction"));
ScheduleDAGInstrs::ScheduleDAGInstrs(MachineFunction &mf,
const MachineLoopInfo &mli,

8
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
View File

@ -56,14 +56,8 @@ namespace {
CombinerGlobalAA("combiner-global-alias-analysis", cl::Hidden,
cl::desc("Enable DAG combiner's use of IR alias analysis"));
// FIXME: Enable the use of TBAA. There are two known issues preventing this:
// 1. Stack coloring does not update TBAA when merging allocas
// 2. CGP inserts ptrtoint/inttoptr pairs when sinking address computations.
// Because BasicAA does not handle inttoptr, we'll often miss basic type
// punning idioms that we need to catch so we don't miscompile real-world
// code.
static cl::opt<bool>
UseTBAA("combiner-use-tbaa", cl::Hidden, cl::init(false),
UseTBAA("combiner-use-tbaa", cl::Hidden, cl::init(true),
cl::desc("Enable DAG combiner's use of TBAA"));
#ifndef NDEBUG

2
test/CodeGen/PowerPC/aa-tbaa.ll
View File

@ -1,4 +1,4 @@
; RUN: llc -enable-misched -misched=shuffle -enable-aa-sched-mi -post-RA-scheduler=0 -mcpu=ppc64 < %s | FileCheck %s
; RUN: llc -enable-misched -misched=shuffle -enable-aa-sched-mi -use-tbaa-in-sched-mi=0 -post-RA-scheduler=0 -mcpu=ppc64 < %s | FileCheck %s
; REQUIRES: asserts
; -misched=shuffle is NDEBUG only!

3
test/CodeGen/SystemZ/alias-01.ll
View File

@ -2,9 +2,6 @@
;
; RUN: llc < %s -mtriple=s390x-linux-gnu | FileCheck %s
; The use of TBAA in CodeGen has been temporarily disabled pending correctness fixes.
; XFAIL: *
; Check that there are no spills.
define void @f1(<16 x i32> *%src1, <16 x float> *%dest) {
; CHECK-LABEL: f1: