From e5ca0ac36be44057ba5a5ad300c685b7967ff5ec Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Fri, 24 Jul 2009 16:53:52 +0000 Subject: [PATCH] tidy up git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@76975 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/TargetAsmInfo.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/Target/TargetAsmInfo.cpp b/lib/Target/TargetAsmInfo.cpp index 829bb902f1e..b3eaadc8e1a 100644 --- a/lib/Target/TargetAsmInfo.cpp +++ b/lib/Target/TargetAsmInfo.cpp @@ -251,10 +251,10 @@ static unsigned GetSectionFlagsForNamedELFSection(const char *Name) { SectionKind::Kind TargetAsmInfo::SectionKindForGlobal(const GlobalValue *GV) const { // Early exit - functions should be always in text sections. - if (isa(GV)) + const GlobalVariable *GVar = dyn_cast(GV); + if (GVar == 0) return SectionKind::Text; - const GlobalVariable* GVar = dyn_cast(GV); bool isThreadLocal = GVar->isThreadLocal(); assert(GVar && "Invalid global value for section selection"); @@ -308,9 +308,10 @@ const Section *TargetAsmInfo::SectionForGlobal(const GlobalValue *GV) const { if (GV->isWeakForLinker()) { if (const char *Prefix = getSectionPrefixForUniqueGlobal(SectionKindForGlobal(GV))) { + unsigned Flags = SectionFlagsForGlobal(GV, SectionKindForGlobal(GV)); + // FIXME: Use mangler interface (PR4584). std::string Name = Prefix+GV->getNameStr(); - unsigned Flags = SectionFlagsForGlobal(GV, SectionKindForGlobal(GV)); return getNamedSection(Name.c_str(), Flags); } }