From e7ff00846244c73836d8ef2fb7f6ffed3c00b60e Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 16 Jul 2013 14:04:08 +0000 Subject: [PATCH] [Support] Fix some warnings when self-hosting clang on Windows git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@186413 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/ErrorHandling.cpp | 5 +++++ lib/Support/Windows/Path.inc | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/Support/ErrorHandling.cpp b/lib/Support/ErrorHandling.cpp index f4b591e777e..9425445a853 100644 --- a/lib/Support/ErrorHandling.cpp +++ b/lib/Support/ErrorHandling.cpp @@ -96,4 +96,9 @@ void llvm::llvm_unreachable_internal(const char *msg, const char *file, dbgs() << " at " << file << ":" << line; dbgs() << "!\n"; abort(); +#ifdef LLVM_BUILTIN_UNREACHABLE + // Windows systems and possibly others don't declare abort() to be noreturn, + // so use the unreachable builtin to avoid a Clang self-host warning. + LLVM_BUILTIN_UNREACHABLE; +#endif } diff --git a/lib/Support/Windows/Path.inc b/lib/Support/Windows/Path.inc index 5787636aa68..5a62a609b83 100644 --- a/lib/Support/Windows/Path.inc +++ b/lib/Support/Windows/Path.inc @@ -756,7 +756,6 @@ error_code mapped_file_region::init(int FD, bool CloseFD, uint64_t Offset) { case readonly: flprotect = PAGE_READONLY; break; case readwrite: flprotect = PAGE_READWRITE; break; case priv: flprotect = PAGE_WRITECOPY; break; - default: llvm_unreachable("invalid mapping mode"); } FileMappingHandle = ::CreateFileMapping(FileHandle, @@ -780,7 +779,6 @@ error_code mapped_file_region::init(int FD, bool CloseFD, uint64_t Offset) { case readonly: dwDesiredAccess = FILE_MAP_READ; break; case readwrite: dwDesiredAccess = FILE_MAP_WRITE; break; case priv: dwDesiredAccess = FILE_MAP_COPY; break; - default: llvm_unreachable("invalid mapping mode"); } Mapping = ::MapViewOfFile(FileMappingHandle, dwDesiredAccess,