6502/llvm-6502
1
0
Fork 0
mirror of https://github.com/c64scene-ar/llvm-6502.git synced 2025-07-15 19:24:33 +00:00
Code Issues Projects Releases Wiki Activity

[TableGen] Use 'isa' to identify UnsetInits rather than comparing with the singleton object created by UnsetInit::get(). Makes it more consistent with the other types.

Browse Source 
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@235465 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Craig Topper
2015-04-22 02:09:45 +00:00
parent 87b4c04980
commit f8012eb826
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/TableGen/Record.cpp
View File

@@ -517,7 +517,7 @@ std::string BitsInit::getAsString() const {
// bits initializer will resolve into VarBitInit to keep the field name and bit // bits initializer will resolve into VarBitInit to keep the field name and bit
// number used in targets with fixed insn length. // number used in targets with fixed insn length.
static Init *fixBitInit(const RecordVal *RV, Init *Before, Init *After) { static Init *fixBitInit(const RecordVal *RV, Init *Before, Init *After) {
if (RV || After != UnsetInit::get()) if (RV || !isa<UnsetInit>(After))
return After; return After;
return Before; return Before;
} }
@@ -1961,7 +1961,7 @@ bool Record::getValueAsBitOrUnset(StringRef FieldName, bool &Unset) const {
PrintFatalError(getLoc(), "Record `" + getName() + PrintFatalError(getLoc(), "Record `" + getName() +
"' does not have a field named `" + FieldName.str() + "'!\n"); "' does not have a field named `" + FieldName.str() + "'!\n");
if (R->getValue() == UnsetInit::get()) { if (isa<UnsetInit>(R->getValue())) {
Unset = true; Unset = true;
return false; return false;
} }

2
utils/TableGen/CodeGenDAGPatterns.cpp
View File

@@ -2064,7 +2064,7 @@ TreePatternNode *TreePattern::ParseTreePattern(Init *TheInit, StringRef OpName){
} }
// ?:$name or just $name. // ?:$name or just $name.
if (TheInit == UnsetInit::get()) { if (isa<UnsetInit>(TheInit)) {
if (OpName.empty()) if (OpName.empty())
error("'?' argument requires a name to match with operand list"); error("'?' argument requires a name to match with operand list");
TreePatternNode *Res = new TreePatternNode(TheInit, 1); TreePatternNode *Res = new TreePatternNode(TheInit, 1);

2
utils/TableGen/DAGISelMatcherGen.cpp
View File

@@ -220,7 +220,7 @@ void MatcherGen::EmitLeafMatchCode(const TreePatternNode *N) {
} }
// An UnsetInit represents a named node without any constraints. // An UnsetInit represents a named node without any constraints.
if (N->getLeafValue() == UnsetInit::get()) { if (isa<UnsetInit>(N->getLeafValue())) {
assert(N->hasName() && "Unnamed ? leaf"); assert(N->hasName() && "Unnamed ? leaf");
return; return;
} }